Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(372)

Side by Side Diff: third_party/WebKit/Source/web/WebViewFrameWidget.h

Issue 2773003002: Make the WebWidgetClient parameter a ref so it's not legal to pass a nullptr. (Closed)
Patch Set: WebViewClient dtor now overrides the virtual dtor in WebWidgetClient. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be found 2 // Use of this source code is governed by a BSD-style license that can be found
3 // in the LICENSE file. 3 // in the LICENSE file.
4 4
5 #ifndef WebViewFrameWidget_h 5 #ifndef WebViewFrameWidget_h
6 #define WebViewFrameWidget_h 6 #define WebViewFrameWidget_h
7 7
8 #include "platform/heap/Handle.h" 8 #include "platform/heap/Handle.h"
9 #include "web/WebFrameWidgetBase.h" 9 #include "web/WebFrameWidgetBase.h"
10 #include "web/WebInputMethodControllerImpl.h" 10 #include "web/WebInputMethodControllerImpl.h"
(...skipping 18 matching lines...) Expand all
29 // After the embedder starts using a WebFrameWidget for the main frame, 29 // After the embedder starts using a WebFrameWidget for the main frame,
30 // WebView will be updated to no longer inherit WebWidget. The eventual goal is 30 // WebView will be updated to no longer inherit WebWidget. The eventual goal is
31 // to unfork the widget code duplicated in WebFrameWidgetImpl and WebViewImpl 31 // to unfork the widget code duplicated in WebFrameWidgetImpl and WebViewImpl
32 // into one class. 32 // into one class.
33 // A more detailed writeup of this transition can be read at 33 // A more detailed writeup of this transition can be read at
34 // https://goo.gl/7yVrnb. 34 // https://goo.gl/7yVrnb.
35 class WebViewFrameWidget : public WebFrameWidgetBase { 35 class WebViewFrameWidget : public WebFrameWidgetBase {
36 WTF_MAKE_NONCOPYABLE(WebViewFrameWidget); 36 WTF_MAKE_NONCOPYABLE(WebViewFrameWidget);
37 37
38 public: 38 public:
39 explicit WebViewFrameWidget(WebWidgetClient*, 39 explicit WebViewFrameWidget(WebWidgetClient&,
40 WebViewImpl&, 40 WebViewImpl&,
41 WebLocalFrameImpl&); 41 WebLocalFrameImpl&);
42 virtual ~WebViewFrameWidget(); 42 virtual ~WebViewFrameWidget();
43 43
44 // WebFrameWidget overrides: 44 // WebFrameWidget overrides:
45 void close() override; 45 void close() override;
46 WebSize size() override; 46 WebSize size() override;
47 void resize(const WebSize&) override; 47 void resize(const WebSize&) override;
48 void resizeVisualViewport(const WebSize&) override; 48 void resizeVisualViewport(const WebSize&) override;
49 void didEnterFullscreen() override; 49 void didEnterFullscreen() override;
(...skipping 54 matching lines...) Expand 10 before | Expand all | Expand 10 after
104 104
105 private: 105 private:
106 WebWidgetClient* m_client; 106 WebWidgetClient* m_client;
107 RefPtr<WebViewImpl> m_webView; 107 RefPtr<WebViewImpl> m_webView;
108 Persistent<WebLocalFrameImpl> m_mainFrame; 108 Persistent<WebLocalFrameImpl> m_mainFrame;
109 }; 109 };
110 110
111 } // namespace blink 111 } // namespace blink
112 112
113 #endif // WebViewFrameWidget_h 113 #endif // WebViewFrameWidget_h
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp ('k') | third_party/WebKit/Source/web/WebViewFrameWidget.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698