ipc/ipc_sync_message_filter.cc - Issue 2772983002: Make sure channel-associated interface pointers are always safe to call.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ipc/ipc_sync_message_filter.cc

Issue 2772983002: Make sure channel-associated interface pointers are always safe to call. (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ipc/ipc_sync_message_filter.cc

diff --git a/ipc/ipc_sync_message_filter.cc b/ipc/ipc_sync_message_filter.cc

index ffccff3d50889271ac0b4c0926b10f62eb9e4ea8..8f4eb6c62fbd8215928136052fbcfafc8373f0ee 100644

--- a/ipc/ipc_sync_message_filter.cc

+++ b/ipc/ipc_sync_message_filter.cc

@@ -276,8 +276,10 @@ void SyncMessageFilter::GetGenericRemoteAssociatedInterface(

mojo::ScopedInterfaceEndpointHandle handle) {

base::AutoLock auto_lock(lock_);

DCHECK(io_task_runner_ && io_task_runner_->BelongsToCurrentThread());

- if (!channel_)

+ if (!channel_) {

+ mojo::GetIsolatedInterface(std::move(handle));

return;

+ }

Channel::AssociatedInterfaceSupport* support =

channel_->GetAssociatedInterfaceSupport();