Remove trailing semicolons to make the tests pass with Fasta.

Remove trailing semicolons to make the tests pass with Fasta.

The Fasta's unit test checks that the token stream is fully consumed,
i.e. that the next token after the parsed entity is EOF.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/0adfef94716bfd276cabe9be93c241f81b8292a7

[Brian Wilkerson, 2017-03-24 19:42:43]

I have concerns about the implications this has for recovery. I don't know the
fasta test framework well enough, so perhaps this concern is not valid in this
case. If you can assure me that this won't degrade our ability to test parser
recovery, then lgtm.

[scheglov, 2017-03-24 19:50:10]

The alternative is to remove the EOF check.
PTAL

[Brian Wilkerson, 2017-03-24 19:59:51]

I don't understand the trade-offs, so I'll defer to Paul.

[Paul Berry, 2017-03-24 20:28:31]

Patch set 1 (keep the EOF check, drop the semicolons) lgtm.

Brian, I'm curious to hear more details about what concerns you have regarding
error recovery.  Feel free to talk to me in person sometime today--we can always
revert this CL if we come up with a better way.

[scheglov, 2017-03-24 21:34:57]

Description was changed from

==========
Remove trailing semicolons to make the tests pass with Fasta.

The Fasta's unit test checks that the token stream is fully consumed,
i.e. that the next token after the parsed entity is EOF.

R=brianwilkerson@google.com, paulberry@google.com
BUG=
==========

to

==========
Remove trailing semicolons to make the tests pass with Fasta.

The Fasta's unit test checks that the token stream is fully consumed,
i.e. that the next token after the parsed entity is EOF.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/0adfef94716bfd276cabe9be93c241f81b8292a7
==========

[scheglov, 2017-03-24 21:34:58]

Committed patchset #2 (id:20001) manually as
0adfef94716bfd276cabe9be93c241f81b8292a7 (presubmit successful).