Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Unified Diff: pkg/analyzer/lib/src/dart/constant/evaluation.dart

Issue 2772943002: store constructor and arguments for constant values (Closed)
Patch Set: clean up import Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/analyzer/lib/src/dart/constant/value.dart » ('j') | pkg/analyzer/pubspec.yaml » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/lib/src/dart/constant/evaluation.dart
diff --git a/pkg/analyzer/lib/src/dart/constant/evaluation.dart b/pkg/analyzer/lib/src/dart/constant/evaluation.dart
index 2e0d063e80d1220a2c72c794010625cd64a073d0..df6c8191413ab7f029f9cdd62944ffba806266bf 100644
--- a/pkg/analyzer/lib/src/dart/constant/evaluation.dart
+++ b/pkg/analyzer/lib/src/dart/constant/evaluation.dart
@@ -422,7 +422,10 @@ class ConstantEvaluationEngine {
List<Expression> arguments,
ConstructorElement constructor,
ConstantVisitor constantVisitor,
- ErrorReporter errorReporter) {
+ ErrorReporter errorReporter,
+ {ConstructorElement originalConstructor,
+ List<DartObjectImpl> originalArguments,
+ Map<String, DartObjectImpl> originalNamedArguments}) {
if (!getConstructorImpl(constructor).isCycleFree) {
// It's not safe to evaluate this constructor, so bail out.
// TODO(paulberry): ensure that a reasonable error message is produced
@@ -434,6 +437,7 @@ class ConstantEvaluationEngine {
int argumentCount = arguments.length;
List<DartObjectImpl> argumentValues =
new List<DartObjectImpl>(argumentCount);
+ List<DartObjectImpl> positionalArguments = <DartObjectImpl>[];
List<Expression> argumentNodes = new List<Expression>(argumentCount);
HashMap<String, DartObjectImpl> namedArgumentValues =
new HashMap<String, DartObjectImpl>();
@@ -448,10 +452,17 @@ class ConstantEvaluationEngine {
namedArgumentNodes[name] = argument;
argumentValues[i] = typeProvider.nullObject;
} else {
- argumentValues[i] = constantVisitor._valueOf(argument);
+ var argumentValue = constantVisitor._valueOf(argument);
+ argumentValues[i] = argumentValue;
+ positionalArguments.add(argumentValue);
argumentNodes[i] = argument;
}
}
+ if (originalConstructor == null) {
+ originalConstructor = constructor;
+ originalArguments = positionalArguments;
+ originalNamedArguments = namedArgumentValues;
+ }
constructor = followConstantRedirectionChain(constructor);
InterfaceType definingClass = constructor.returnType as InterfaceType;
if (constructor.isFactory) {
@@ -709,7 +720,10 @@ class ConstantEvaluationEngine {
initializer.argumentList.arguments,
constructor,
initializerVisitor,
- errorReporter);
+ errorReporter,
+ originalConstructor: originalConstructor,
+ originalArguments: originalArguments,
+ originalNamedArguments: originalNamedArguments);
}
}
}
@@ -727,7 +741,12 @@ class ConstantEvaluationEngine {
superArguments, initializerVisitor, errorReporter);
}
}
- return new DartObjectImpl(definingClass, new GenericState(fieldMap));
+ return new DartObjectImpl(
+ definingClass,
+ new GenericState(fieldMap,
+ constructor: originalConstructor,
+ positionalArguments: originalArguments,
+ namedArguments: originalNamedArguments));
}
void evaluateSuperConstructorCall(
« no previous file with comments | « no previous file | pkg/analyzer/lib/src/dart/constant/value.dart » ('j') | pkg/analyzer/pubspec.yaml » ('J')

Powered by Google App Engine
This is Rietveld 408576698