store constructor and arguments for constant values

store constructor and arguments for constant values

R=brianwilkerson@google.com

Committed: https://github.com/dart-lang/sdk/commit/eb712bb76747d5c9b79711ec26f4fc6642e87dff

[Harry Terkelsen, 2017-03-23 22:13:25]

het@google.com changed reviewers:
+ brianwilkerson@google.com

[Brian Wilkerson, 2017-03-24 15:25:19]

Sorry for the delay, I missed the original e-mail.

Given that we have three fields that either all must be provided or all must not
be provided, I think it would be cleaner to introduce a new class to encapsulate
those fields (something like "ConstructorInvocation") and then pass / store a
single object. What do you think?

https://codereview.chromium.org/2772943002/diff/40001/pkg/analyzer/pubspec.yaml
File pkg/analyzer/pubspec.yaml (right):

https://codereview.chromium.org/2772943002/diff/40001/pkg/analyzer/pubspec.ya...
pkg/analyzer/pubspec.yaml:2: version: 0.30.0-alpha.2
There's no reason to bump the version number; we have not yet published a 0.30
version.

[Harry Terkelsen, 2017-03-24 16:52:21]

Thanks, Brian!
I think it's cleaner to have all the information in a class. PTAL

https://codereview.chromium.org/2772943002/diff/40001/pkg/analyzer/pubspec.yaml
File pkg/analyzer/pubspec.yaml (right):

https://codereview.chromium.org/2772943002/diff/40001/pkg/analyzer/pubspec.ya...
pkg/analyzer/pubspec.yaml:2: version: 0.30.0-alpha.2
On 2017/03/24 15:25:19, Brian Wilkerson wrote:
> There's no reason to bump the version number; we have not yet published a 0.30
> version.

Done.

[Brian Wilkerson, 2017-03-24 18:32:21]

lgtm, thanks!

[Harry Terkelsen, 2017-03-24 18:33:11]

Description was changed from

==========
store constructor and arguments for constant values
==========

to

==========
store constructor and arguments for constant values

R=brianwilkerson@google.com

Committed:
https://github.com/dart-lang/sdk/commit/eb712bb76747d5c9b79711ec26f4fc6642e87dff
==========

[Harry Terkelsen, 2017-03-24 18:33:12]

Committed patchset #5 (id:80001) manually as
eb712bb76747d5c9b79711ec26f4fc6642e87dff (presubmit successful).