Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(996)

Issue 2772803002: Revert "Use canonical names for some name-based lookup." (Closed)

Created:
3 years, 9 months ago by Kevin Millikin (Google)
Modified:
3 years, 9 months ago
Reviewers:
jensj
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Use canonical names for some name-based lookup." This reverts commit a15b8c49ea195345f542d4efbe8d6dd29268d030. BUG= Committed: https://github.com/dart-lang/sdk/commit/91bc604415e0d64fa7bd0059210e74ce0f8dd1fe

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -73 lines) Patch
M runtime/vm/kernel.h View 3 chunks +4 lines, -6 lines 0 comments Download
M runtime/vm/kernel_reader.h View 3 chunks +6 lines, -6 lines 0 comments Download
M runtime/vm/kernel_reader.cc View 7 chunks +28 lines, -29 lines 0 comments Download
M runtime/vm/kernel_to_il.h View 3 chunks +4 lines, -4 lines 0 comments Download
M runtime/vm/kernel_to_il.cc View 16 chunks +27 lines, -28 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Kevin Millikin (Google)
TBR'd. This change alters library names by using the import URI instead of the name. ...
3 years, 9 months ago (2017-03-23 13:20:43 UTC) #2
Kevin Millikin (Google)
3 years, 9 months ago (2017-03-23 13:20:51 UTC) #3
Kevin Millikin (Google)
Committed patchset #1 (id:1) manually as 91bc604415e0d64fa7bd0059210e74ce0f8dd1fe (presubmit successful).
3 years, 9 months ago (2017-03-23 13:21:13 UTC) #5
jensj
3 years, 9 months ago (2017-03-23 13:21:41 UTC) #6
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698