Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1710)

Unified Diff: third_party/WebKit/Source/core/loader/FrameFetchContext.cpp

Issue 2772753002: Change FrameLoadTypeReload to take FrameLoadTypeReloadMainResource's behavior (Closed)
Patch Set: remove Reload Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/loader/FrameFetchContext.cpp
diff --git a/third_party/WebKit/Source/core/loader/FrameFetchContext.cpp b/third_party/WebKit/Source/core/loader/FrameFetchContext.cpp
index 5f8ca3e28039e6fc019e2d530e25f246699ca152..f68d8e63207545f5e29ad204da76d80481dc3587 100644
--- a/third_party/WebKit/Source/core/loader/FrameFetchContext.cpp
+++ b/third_party/WebKit/Source/core/loader/FrameFetchContext.cpp
@@ -253,8 +253,6 @@ WebCachePolicy determineWebCachePolicy(RequestMethod method,
return method == RequestMethod::kIsPost
? WebCachePolicy::ReturnCacheDataDontLoad
: WebCachePolicy::ReturnCacheDataElseLoad;
- case FrameLoadTypeReload:
- return WebCachePolicy::ValidatingCacheData;
case FrameLoadTypeReloadMainResource:
return resourceType == ResourceType::kIsMainResource
? WebCachePolicy::ValidatingCacheData
@@ -375,7 +373,7 @@ void FrameFetchContext::addAdditionalRequestHeaders(ResourceRequest& request,
if (!request.url().isEmpty() && !request.url().protocolIsInHTTPFamily())
return;
- if (masterDocumentLoader()->loadType() == FrameLoadTypeReload)
+ if (masterDocumentLoader()->loadType() == FrameLoadTypeReloadMainResource)
Takashi Toyoshima 2017/03/23 08:45:42 This will cause a behavior change. Introduced by
Takashi Toyoshima 2017/03/24 03:29:17 Resolved: https://codereview.chromium.org/27690330
request.clearHTTPHeaderField("Save-Data");
if (frame()->settings() && frame()->settings()->getDataSaverEnabled())

Powered by Google App Engine
This is Rietveld 408576698