Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Unified Diff: chrome/browser/extensions/tab_helper.cc

Issue 2772713002: Remove IDC_CREATE_SHORTCUT and its associated UI. (Closed)
Patch Set: iwyu Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/tab_helper.cc
diff --git a/chrome/browser/extensions/tab_helper.cc b/chrome/browser/extensions/tab_helper.cc
index f85e854b63c31cfd75b15b6b227605ca4877b864..a7353e0f94e68e67a6a1724f7f332d15b510caa1 100644
--- a/chrome/browser/extensions/tab_helper.cc
+++ b/chrome/browser/extensions/tab_helper.cc
@@ -198,16 +198,6 @@ TabHelper::~TabHelper() {
RemoveScriptExecutionObserver(ActivityLog::GetInstance(profile_));
}
-void TabHelper::CreateApplicationShortcuts() {
- DCHECK(CanCreateApplicationShortcuts());
- if (pending_web_app_action_ != NONE)
- return;
-
- // Start fetching web app info for CreateApplicationShortcut dialog and show
- // the dialog when the data is available in OnDidGetApplicationInfo.
- GetApplicationInfo(CREATE_SHORTCUT);
-}
-
void TabHelper::CreateHostedAppFromWebContents() {
DCHECK(CanCreateBookmarkApp());
if (pending_web_app_action_ != NONE)
@@ -218,14 +208,6 @@ void TabHelper::CreateHostedAppFromWebContents() {
GetApplicationInfo(CREATE_HOSTED_APP);
}
-bool TabHelper::CanCreateApplicationShortcuts() const {
-#if defined(OS_MACOSX)
- return false;
-#else
- return web_app::IsValidUrl(web_contents()->GetURL());
-#endif
-}
-
bool TabHelper::CanCreateBookmarkApp() const {
return !profile_->IsGuestSession() &&
!profile_->IsSystemProfile() &&
@@ -398,14 +380,6 @@ void TabHelper::OnDidGetWebApplicationInfo(const WebApplicationInfo& info) {
last_committed_nav_entry_unique_id_ = 0;
switch (pending_web_app_action_) {
-#if !defined(OS_MACOSX)
- case CREATE_SHORTCUT: {
- chrome::ShowCreateWebAppShortcutsDialog(
- web_contents()->GetTopLevelNativeWindow(),
- web_contents());
- break;
- }
-#endif
case CREATE_HOSTED_APP: {
if (web_app_info_.app_url.is_empty())
web_app_info_.app_url = web_contents()->GetURL();

Powered by Google App Engine
This is Rietveld 408576698