Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1980)

Unified Diff: chrome/browser/ui/toolbar/app_menu_model.cc

Issue 2772713002: Remove IDC_CREATE_SHORTCUT and its associated UI. (Closed)
Patch Set: respond to comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/toolbar/app_menu_model.cc
diff --git a/chrome/browser/ui/toolbar/app_menu_model.cc b/chrome/browser/ui/toolbar/app_menu_model.cc
index 7ef2d8ba5794dbd1cc42f69383d7da3e3ba8e293..6092a5e4ccb2e3e2189cd12f278d1e38efd2627d 100644
--- a/chrome/browser/ui/toolbar/app_menu_model.cc
+++ b/chrome/browser/ui/toolbar/app_menu_model.cc
@@ -176,10 +176,6 @@ ToolsMenuModel::~ToolsMenuModel() {}
// - Developer tools.
// - Option to enable profiling.
void ToolsMenuModel::Build(Browser* browser) {
- bool show_create_shortcuts = true;
-#if defined(OS_CHROMEOS) || defined(OS_MACOSX) || defined(USE_ASH)
- show_create_shortcuts = false;
-#endif
if (base::CommandLine::ForCurrentProcess()->HasSwitch(
switches::kEnableSaveAsMenuLabelExperiment) ||
base::FieldTrialList::FindFullName("SaveAsMenuText") == "download") {
@@ -197,8 +193,6 @@ void ToolsMenuModel::Build(Browser* browser) {
string_id = IDS_ADD_TO_SHELF;
#endif // defined(USE_ASH)
AddItemWithStringId(IDC_CREATE_HOSTED_APP, string_id);
- } else if (show_create_shortcuts) {
- AddItemWithStringId(IDC_CREATE_SHORTCUTS, IDS_CREATE_SHORTCUTS);
}
AddSeparator(ui::NORMAL_SEPARATOR);
@@ -437,12 +431,6 @@ void AppMenuModel::LogMenuMetrics(int command_id) {
}
LogMenuAction(MENU_ACTION_CREATE_HOSTED_APP);
break;
- case IDC_CREATE_SHORTCUTS:
- if (!uma_action_recorded_)
- UMA_HISTOGRAM_MEDIUM_TIMES("WrenchMenu.TimeToAction.CreateShortcuts",
- delta);
- LogMenuAction(MENU_ACTION_CREATE_SHORTCUTS);
- break;
case IDC_MANAGE_EXTENSIONS:
if (!uma_action_recorded_) {
UMA_HISTOGRAM_MEDIUM_TIMES("WrenchMenu.TimeToAction.ManageExtensions",

Powered by Google App Engine
This is Rietveld 408576698