Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Unified Diff: chrome/browser/ui/browser_command_controller.cc

Issue 2772713002: Remove IDC_CREATE_SHORTCUT and its associated UI. (Closed)
Patch Set: respond to comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/browser_command_controller.cc
diff --git a/chrome/browser/ui/browser_command_controller.cc b/chrome/browser/ui/browser_command_controller.cc
index 764a4c14a4e6118fe37c35dee6c901f295877869..38d517a9b57f023127bd554cba874ddd6974b5c0 100644
--- a/chrome/browser/ui/browser_command_controller.cc
+++ b/chrome/browser/ui/browser_command_controller.cc
@@ -512,9 +512,6 @@ void BrowserCommandController::ExecuteCommandWithDisposition(
case IDC_OPEN_FILE:
browser_->OpenFile();
break;
- case IDC_CREATE_SHORTCUTS:
- CreateApplicationShortcuts(browser_);
- break;
case IDC_CREATE_HOSTED_APP:
CreateBookmarkAppFromCurrentWebContents(browser_);
break;
@@ -771,7 +768,6 @@ void BrowserCommandController::InitCommandState() {
<< "Ought to never have browser for the system profile.";
const bool normal_window = browser_->is_type_tabbed();
UpdateOpenFileState(&command_updater_);
- command_updater_.UpdateCommandEnabled(IDC_CREATE_SHORTCUTS, false);
UpdateCommandsForDevTools();
command_updater_.UpdateCommandEnabled(IDC_TASK_MANAGER, CanOpenTaskManager());
command_updater_.UpdateCommandEnabled(IDC_SHOW_HISTORY, !guest_session);
@@ -914,14 +910,6 @@ void BrowserCommandController::UpdateCommandsForTabState() {
if (browser_->is_devtools())
command_updater_.UpdateCommandEnabled(IDC_OPEN_FILE, false);
- // Show various bits of UI
- // TODO(pinkerton): Disable app-mode in the model until we implement it
- // on the Mac. Be sure to remove both ifdefs. http://crbug.com/13148
-#if !defined(OS_MACOSX)
- command_updater_.UpdateCommandEnabled(
- IDC_CREATE_SHORTCUTS,
- CanCreateApplicationShortcuts(browser_));
-#endif
command_updater_.UpdateCommandEnabled(IDC_CREATE_HOSTED_APP,
CanCreateBookmarkApp(browser_));

Powered by Google App Engine
This is Rietveld 408576698