Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Side by Side Diff: chrome/browser/ui/browser_command_controller.cc

Issue 2772713002: Remove IDC_CREATE_SHORTCUT and its associated UI. (Closed)
Patch Set: iwyu Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/browser_command_controller.h" 5 #include "chrome/browser/ui/browser_command_controller.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include <string> 9 #include <string>
10 10
(...skipping 494 matching lines...) Expand 10 before | Expand all | Expand 10 after
505 FocusNextPane(browser_); 505 FocusNextPane(browser_);
506 break; 506 break;
507 case IDC_FOCUS_PREVIOUS_PANE: 507 case IDC_FOCUS_PREVIOUS_PANE:
508 FocusPreviousPane(browser_); 508 FocusPreviousPane(browser_);
509 break; 509 break;
510 510
511 // Show various bits of UI 511 // Show various bits of UI
512 case IDC_OPEN_FILE: 512 case IDC_OPEN_FILE:
513 browser_->OpenFile(); 513 browser_->OpenFile();
514 break; 514 break;
515 case IDC_CREATE_SHORTCUTS:
516 CreateApplicationShortcuts(browser_);
517 break;
518 case IDC_CREATE_HOSTED_APP: 515 case IDC_CREATE_HOSTED_APP:
519 CreateBookmarkAppFromCurrentWebContents(browser_); 516 CreateBookmarkAppFromCurrentWebContents(browser_);
520 break; 517 break;
521 case IDC_DEV_TOOLS: 518 case IDC_DEV_TOOLS:
522 ToggleDevToolsWindow(browser_, DevToolsToggleAction::Show()); 519 ToggleDevToolsWindow(browser_, DevToolsToggleAction::Show());
523 break; 520 break;
524 case IDC_DEV_TOOLS_CONSOLE: 521 case IDC_DEV_TOOLS_CONSOLE:
525 ToggleDevToolsWindow(browser_, DevToolsToggleAction::ShowConsolePanel()); 522 ToggleDevToolsWindow(browser_, DevToolsToggleAction::ShowConsolePanel());
526 break; 523 break;
527 case IDC_DEV_TOOLS_DEVICES: 524 case IDC_DEV_TOOLS_DEVICES:
(...skipping 236 matching lines...) Expand 10 before | Expand all | Expand 10 after
764 command_updater_.UpdateCommandEnabled(IDC_ZOOM_NORMAL, false); 761 command_updater_.UpdateCommandEnabled(IDC_ZOOM_NORMAL, false);
765 command_updater_.UpdateCommandEnabled(IDC_ZOOM_MINUS, true); 762 command_updater_.UpdateCommandEnabled(IDC_ZOOM_MINUS, true);
766 763
767 // Show various bits of UI 764 // Show various bits of UI
768 const bool guest_session = profile()->IsGuestSession() || 765 const bool guest_session = profile()->IsGuestSession() ||
769 profile()->IsSystemProfile(); 766 profile()->IsSystemProfile();
770 DCHECK(!profile()->IsSystemProfile()) 767 DCHECK(!profile()->IsSystemProfile())
771 << "Ought to never have browser for the system profile."; 768 << "Ought to never have browser for the system profile.";
772 const bool normal_window = browser_->is_type_tabbed(); 769 const bool normal_window = browser_->is_type_tabbed();
773 UpdateOpenFileState(&command_updater_); 770 UpdateOpenFileState(&command_updater_);
774 command_updater_.UpdateCommandEnabled(IDC_CREATE_SHORTCUTS, false);
775 UpdateCommandsForDevTools(); 771 UpdateCommandsForDevTools();
776 command_updater_.UpdateCommandEnabled(IDC_TASK_MANAGER, CanOpenTaskManager()); 772 command_updater_.UpdateCommandEnabled(IDC_TASK_MANAGER, CanOpenTaskManager());
777 command_updater_.UpdateCommandEnabled(IDC_SHOW_HISTORY, !guest_session); 773 command_updater_.UpdateCommandEnabled(IDC_SHOW_HISTORY, !guest_session);
778 command_updater_.UpdateCommandEnabled(IDC_SHOW_DOWNLOADS, true); 774 command_updater_.UpdateCommandEnabled(IDC_SHOW_DOWNLOADS, true);
779 command_updater_.UpdateCommandEnabled(IDC_HELP_MENU, true); 775 command_updater_.UpdateCommandEnabled(IDC_HELP_MENU, true);
780 command_updater_.UpdateCommandEnabled(IDC_HELP_PAGE_VIA_KEYBOARD, true); 776 command_updater_.UpdateCommandEnabled(IDC_HELP_PAGE_VIA_KEYBOARD, true);
781 command_updater_.UpdateCommandEnabled(IDC_HELP_PAGE_VIA_MENU, true); 777 command_updater_.UpdateCommandEnabled(IDC_HELP_PAGE_VIA_MENU, true);
782 command_updater_.UpdateCommandEnabled(IDC_BOOKMARKS_MENU, !guest_session); 778 command_updater_.UpdateCommandEnabled(IDC_BOOKMARKS_MENU, !guest_session);
783 command_updater_.UpdateCommandEnabled(IDC_RECENT_TABS_MENU, 779 command_updater_.UpdateCommandEnabled(IDC_RECENT_TABS_MENU,
784 !guest_session && 780 !guest_session &&
(...skipping 122 matching lines...) Expand 10 before | Expand all | Expand 10 after
907 window()->SetStarredState( 903 window()->SetStarredState(
908 BookmarkTabHelper::FromWebContents(current_web_contents)->is_starred()); 904 BookmarkTabHelper::FromWebContents(current_web_contents)->is_starred());
909 window()->ZoomChangedForActiveTab(false); 905 window()->ZoomChangedForActiveTab(false);
910 command_updater_.UpdateCommandEnabled(IDC_VIEW_SOURCE, 906 command_updater_.UpdateCommandEnabled(IDC_VIEW_SOURCE,
911 CanViewSource(browser_)); 907 CanViewSource(browser_));
912 command_updater_.UpdateCommandEnabled(IDC_EMAIL_PAGE_LOCATION, 908 command_updater_.UpdateCommandEnabled(IDC_EMAIL_PAGE_LOCATION,
913 CanEmailPageLocation(browser_)); 909 CanEmailPageLocation(browser_));
914 if (browser_->is_devtools()) 910 if (browser_->is_devtools())
915 command_updater_.UpdateCommandEnabled(IDC_OPEN_FILE, false); 911 command_updater_.UpdateCommandEnabled(IDC_OPEN_FILE, false);
916 912
917 // Show various bits of UI
918 // TODO(pinkerton): Disable app-mode in the model until we implement it
919 // on the Mac. Be sure to remove both ifdefs. http://crbug.com/13148
920 #if !defined(OS_MACOSX)
921 command_updater_.UpdateCommandEnabled(
922 IDC_CREATE_SHORTCUTS,
923 CanCreateApplicationShortcuts(browser_));
924 #endif
925 command_updater_.UpdateCommandEnabled(IDC_CREATE_HOSTED_APP, 913 command_updater_.UpdateCommandEnabled(IDC_CREATE_HOSTED_APP,
926 CanCreateBookmarkApp(browser_)); 914 CanCreateBookmarkApp(browser_));
927 915
928 command_updater_.UpdateCommandEnabled( 916 command_updater_.UpdateCommandEnabled(
929 IDC_TOGGLE_REQUEST_TABLET_SITE, 917 IDC_TOGGLE_REQUEST_TABLET_SITE,
930 CanRequestTabletSite(current_web_contents)); 918 CanRequestTabletSite(current_web_contents));
931 919
932 UpdateCommandsForContentRestrictionState(); 920 UpdateCommandsForContentRestrictionState();
933 UpdateCommandsForBookmarkEditing(); 921 UpdateCommandsForBookmarkEditing();
934 UpdateCommandsForFind(); 922 UpdateCommandsForFind();
(...skipping 207 matching lines...) Expand 10 before | Expand all | Expand 10 after
1142 1130
1143 BrowserWindow* BrowserCommandController::window() { 1131 BrowserWindow* BrowserCommandController::window() {
1144 return browser_->window(); 1132 return browser_->window();
1145 } 1133 }
1146 1134
1147 Profile* BrowserCommandController::profile() { 1135 Profile* BrowserCommandController::profile() {
1148 return browser_->profile(); 1136 return browser_->profile();
1149 } 1137 }
1150 1138
1151 } // namespace chrome 1139 } // namespace chrome
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698