Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Unified Diff: runtime/vm/il_printer.cc

Issue 27727002: Optimize identical-comparisons based on propagated type information. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/flow_graph_optimizer.cc ('k') | runtime/vm/intermediate_language.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/il_printer.cc
===================================================================
--- runtime/vm/il_printer.cc (revision 28797)
+++ runtime/vm/il_printer.cc (working copy)
@@ -73,7 +73,7 @@
void FlowGraphPrinter::PrintOneInstruction(Instruction* instr,
bool print_locations) {
- char str[1000];
+ char str[4000];
BufferFormatter f(str, sizeof(str));
instr->PrintTo(&f);
if (FLAG_print_environments && (instr->env() != NULL)) {
@@ -97,8 +97,8 @@
const String& dst_name,
bool eliminated) {
const char* compile_type_name = "unknown";
- if (value != NULL) {
- compile_type_name = value->Type()->ToCString();
+ if (value != NULL && value->reaching_type_ != NULL) {
+ compile_type_name = value->reaching_type_->ToCString();
}
OS::Print("%s type check: compile type %s is %s specific than "
"type '%s' of '%s'.\n",
@@ -232,7 +232,7 @@
void Value::PrintTo(BufferFormatter* f) const {
PrintUse(f, *definition());
if ((reaching_type_ != NULL) &&
- (reaching_type_ != definition()->Type())) {
+ (reaching_type_ != definition()->type_)) {
f->Print(" ");
reaching_type_->PrintTo(f);
}
« no previous file with comments | « runtime/vm/flow_graph_optimizer.cc ('k') | runtime/vm/intermediate_language.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698