Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1034)

Unified Diff: runtime/vm/flow_graph_optimizer.cc

Issue 27727002: Optimize identical-comparisons based on propagated type information. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/flow_graph_optimizer.h ('k') | runtime/vm/il_printer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/flow_graph_optimizer.cc
===================================================================
--- runtime/vm/flow_graph_optimizer.cc (revision 28797)
+++ runtime/vm/flow_graph_optimizer.cc (working copy)
@@ -3223,27 +3223,6 @@
}
-static bool MayBeBoxableNumber(intptr_t cid) {
- return (cid == kDynamicCid) ||
- (cid == kMintCid) ||
- (cid == kBigintCid) ||
- (cid == kDoubleCid);
-}
-
-
-// Check if number check is not needed.
-void FlowGraphOptimizer::VisitStrictCompare(StrictCompareInstr* instr) {
- if (!instr->needs_number_check()) return;
-
- // If one of the input is not a boxable number (Mint, Double, Bigint), no
- // need for number checks.
- if (!MayBeBoxableNumber(instr->left()->Type()->ToCid()) ||
- !MayBeBoxableNumber(instr->right()->Type()->ToCid())) {
- instr->set_needs_number_check(false);
- }
-}
-
-
// Range analysis for smi values.
class RangeAnalysis : public ValueObject {
public:
« no previous file with comments | « runtime/vm/flow_graph_optimizer.h ('k') | runtime/vm/il_printer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698