Optimize identical-comparisons based on propagated type information.

runtime/vm/intermediate_language.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/intermediate_language.h"
 
 #include "vm/bigint_operations.h"
 #include "vm/bit_vector.h"
 #include "vm/dart_entry.h"
 #include "vm/flow_graph_allocator.h"
@@ skipping 1611 matching lines @@
       // value of the comparison is not used outside the branch anymore.
       ASSERT(comp->input_use_list() == NULL);
       comp->ClearSSATempIndex();
       comp->ClearTempIndex();
     }
   }
   return this;
 }
 
 
+static bool MayBeBoxableNumber(intptr_t cid) {
+  return (cid == kDynamicCid) ||
+         (cid == kMintCid) ||
+         (cid == kBigintCid) ||
+         (cid == kDoubleCid);
+}
+
+
+static bool MaybeNumber(CompileType* type) {
+  ASSERT(Type::Handle(Type::Number()).IsMoreSpecificThan(
+         Type::Handle(Type::Number()), NULL));
+  return type->ToAbstractType()->IsDynamicType()
+      || type->IsMoreSpecificThan(Type::Handle(Type::Number()));
+}
+
+
 Definition* StrictCompareInstr::Canonicalize(FlowGraph* flow_graph) {
+  // Use propagated cid and type information to eliminate number checks.
+  // If one of the inputs is not a boxable number (Mint, Double, Bigint), or
+  // is not a subtype of num, no need for number checks.
+  if (needs_number_check()) {
+    if (!MayBeBoxableNumber(left()->Type()->ToCid()) ||
+        !MayBeBoxableNumber(right()->Type()->ToCid()))  {
+      set_needs_number_check(false);
+    } else if (!MaybeNumber(left()->Type()) || !MaybeNumber(right()->Type())) {

[srdjan, 2013/10/17 17:06:45]

Wouldn't it be enough to just check for MayBeNumber, i.e., Type() should have
enough information, we do not need to check the exact cid but the subtype
relation only?

[Florian Schneider, 2013/10/18 10:55:27]

It would work, but the check on the AbstractType does not handles smis
separately. I guess I could do that with AbstractType, too, but the check for
cid is more efficient.

+      set_needs_number_check(false);
+    }
+  }
+
   bool negated = false;
   Definition* replacement = CanonicalizeStrictCompare(this, &negated);
   if (negated && replacement->IsComparison()) {
     ASSERT(replacement != this);
     replacement->AsComparison()->NegateComparison();
   }
   return replacement;
 }
 
 
@@ skipping 1128 matching lines @@
       return kCosRuntimeEntry;
     default:
       UNREACHABLE();
   }
   return kSinRuntimeEntry;
 }
 
 #undef __
 
 }  // namespace dart