mash: switch to the new pref service

chrome/common/chrome_features.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/chrome_features.h"
 
+#include "base/command_line.h"
+#include "chrome/common/chrome_switches.h"
 #include "extensions/features/features.h"
 #include "ppapi/features/features.h"
 
 namespace features {
 
 // All features in alphabetical order.
 
 #if defined(OS_ANDROID)
 const base::Feature kAllowAutoplayUnmutedInWebappManifestScope{
     "AllowAutoplayUnmutedInWebappManifestScope",
@@ skipping 282 matching lines @@
 
 // Enables or disables emoji, handwriting and voice input on opt-in IME menu.
 const base::Feature kEHVInputOnImeMenu{"EmojiHandwritingVoiceInput",
                                        base::FEATURE_ENABLED_BY_DEFAULT};
 
 // Enables or disables flash component updates on Chrome OS.
 const base::Feature kCrosCompUpdates{"CrosCompUpdates",
                                      base::FEATURE_ENABLED_BY_DEFAULT};
 #endif  // defined(OS_CHROMEOS)
 
+bool PrefServiceEnabled() {

[Sam McNally, 2017/03/27 05:42:10]

DON'T ADD RANDOM STUFF HERE.

[tibell, 2017/03/28 00:34:31]

ditto

+  return base::FeatureList::IsEnabled(features::kPrefService) ||
+#if BUILDFLAG(ENABLE_PACKAGE_MASH_SERVICES)
+         base::CommandLine::ForCurrentProcess()->GetSwitchValueASCII(
+             switches::kMusConfig) == switches::kMash;

[jonross, 2017/03/27 14:26:38]

I'm a bit concerned about restricting this feature to mash only.

We have been using the IsRunningInMash() pattern a lot as a stopgap. To allow us
to turn off features which we haven't had the chance to implement mojoms for.
This has allowed us to test the system faster.

Once features have been ready we've had them utilize mojo apis both in mash, as
well as in classic ash settings.

There is some upcoming wallpaper and display settings changes with plans to use
the pref service in both modes.

[tibell, 2017/03/28 00:34:31]

See my reply in shell.cc

[jonross, 2017/03/28 13:57:26]

Acknowledged.

+#else
+         false;
+#endif
+}
+
 }  // namespace features