Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1162)

Unified Diff: third_party/WebKit/Source/platform/instrumentation/InstrumentingProbesCodeGenerator.py

Issue 2772613002: [instrumentation] Rename InspectorInstrumentation into CoreProbes (Closed)
Patch Set: sinkFor -> toCoreProbesSink Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/instrumentation/InstrumentingProbesCodeGenerator.py
diff --git a/third_party/WebKit/Source/platform/instrumentation/InstrumentingProbesCodeGenerator.py b/third_party/WebKit/Source/platform/instrumentation/InstrumentingProbesCodeGenerator.py
index 695711960b7e303abac7f28a73665f219be059ea..a553b789aa339cecb482b7cc4d9300863fff8fe1 100644
--- a/third_party/WebKit/Source/platform/instrumentation/InstrumentingProbesCodeGenerator.py
+++ b/third_party/WebKit/Source/platform/instrumentation/InstrumentingProbesCodeGenerator.py
@@ -16,7 +16,7 @@ import sys
# is regenerated, which causes a race condition and breaks concurrent build,
# since some compile processes will try to read the partially written cache.
module_path, module_filename = os.path.split(os.path.realpath(__file__))
-templates_dir = module_path
+templates_dir = os.path.join(module_path, "templates")
third_party_dir = os.path.normpath(os.path.join(
module_path, os.pardir, os.pardir, os.pardir, os.pardir))
# jinja2 is in chromium's third_party directory.
@@ -112,6 +112,8 @@ def include_inspector_header(name):
return include_header("core/frame/" + name)
if name == "PlatformInstrumentation":
return include_header("platform/instrumentation/" + name)
+ if name == "CoreProbes":
+ return include_header("core/instrumentation/" + name)
return include_header("core/inspector/" + name)
@@ -228,19 +230,19 @@ template_context = {
"name": base_name,
"input_file": os.path.basename(input_path)
}
-cpp_template = jinja_env.get_template("/InstrumentingProbesImpl_cpp.template")
+cpp_template = jinja_env.get_template("/InstrumentingProbesImpl.cpp.tmpl")
cpp_file = open(output_dirpath + "/" + base_name + "Impl.cpp", "w")
cpp_file.write(cpp_template.render(template_context))
cpp_file.close()
-agents_h_template = jinja_env.get_template("/InstrumentingAgents_h.template")
-agents_h_file = open(output_dirpath + "/" + base_name + "Agents.h", "w")
-agents_h_file.write(agents_h_template.render(template_context))
-agents_h_file.close()
+sink_h_template = jinja_env.get_template("/ProbesSink.h.tmpl")
+sink_h_file = open(output_dirpath + "/" + base_name + "Sink.h", "w")
+sink_h_file.write(sink_h_template.render(template_context))
+sink_h_file.close()
for f in files:
template_context["file"] = f
- h_template = jinja_env.get_template("/InstrumentingProbesImpl_h.template")
+ h_template = jinja_env.get_template("/InstrumentingProbesInl.h.tmpl")
h_file = open(output_dirpath + "/" + f.header_name + ".h", "w")
h_file.write(h_template.render(template_context))
h_file.close()

Powered by Google App Engine
This is Rietveld 408576698