Issue 2772583006: PlzNavigate: load the fallback URL of intents asynchronously

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2772583006: PlzNavigate: load the fallback URL of intents asynchronously (Closed)

Created:
3 years, 9 months ago by wychen

Modified:
3 years, 9 months ago

Reviewers:

CC:
chromium-reviews, agrieve+watch_chromium.org

Target Ref:
refs/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

PlzNavigate: load the fallback URL of intents asynchronously When loaded synchronously, the navigation handle would be destructed prematurely, so that the error code couldn't be properly reported back. This fixes: externalnav.UrlOverridingTest#testNavigationWithFallbackURL BUG=699388

Patch Set 1 #

Created: 3 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -2 lines)			Patch
	M	chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegateImpl.java	View		3 chunks	+12 lines, -2 lines	0 comments	Download

Depends on Patchset:

Issue 2385413004 Patch 1070001

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

wychen

3 years, 9 months ago (2017-03-24 22:36:37 UTC) #1

https://codereview.chromium.org/2768873006/ fixed the issue. Close.

Expand Messages | Collapse Messages