Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(415)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2772573003: Handle casts from Number to FutureOr<double>. (Closed)

Created:
3 years, 9 months ago by Leaf
Modified:
3 years, 9 months ago
Reviewers:
vsm
CC:
dev-compiler+reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Use subtype check instead #

Patch Set 3 : Formatting #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -1 line) Patch
M pkg/dev_compiler/lib/sdk/ddc_sdk.sum View 1 2 Binary file 0 comments Download
M pkg/dev_compiler/test/browser/runtime_tests.js View 1 2 2 chunks +18 lines, -0 lines 0 comments Download
M pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Leaf
I did regenerate the sdk.js files, but the rietveld is refusing to upload the diff ...
3 years, 9 months ago (2017-03-23 19:30:48 UTC) #2
vsm
https://codereview.chromium.org/2772573003/diff/1/pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart File pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart (right): https://codereview.chromium.org/2772573003/diff/1/pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart#newcode500 pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart:500: (actual == $int && $_isFutureOr(type) Can type be FutureOr<FutureOr<T>> ...
3 years, 9 months ago (2017-03-23 19:37:44 UTC) #3
Leaf
PTAL https://codereview.chromium.org/2772573003/diff/1/pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart File pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart (right): https://codereview.chromium.org/2772573003/diff/1/pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart#newcode500 pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart:500: (actual == $int && $_isFutureOr(type) On 2017/03/23 19:37:44, ...
3 years, 9 months ago (2017-03-23 20:27:32 UTC) #4
vsm
lgtm
3 years, 9 months ago (2017-03-23 20:28:18 UTC) #5
Leaf
3 years, 9 months ago (2017-03-23 20:33:45 UTC) #7
Message was sent while issue was closed. 
Committed patchset #3 (id:20001) manually as
dba842bcc8a6c96440aa9f8629c0c62f5675a2d0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698