Issue 2772563002: Fix the fix for the native symbol resolver on Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2772563002: Fix the fix for the native symbol resolver on Windows. (Closed)

Created:
3 years, 9 months ago by Florian Schneider

Modified:
3 years, 9 months ago

Reviewers:
Cutch

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Fix the fix for the native symbol resolver on Windows. The 'start' output parameter is optional, so check for NULL is required. BUG= R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/030473f0ffb4bb72fa35d3995fe735fb9731e1fd

Created: 3 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	runtime/vm/native_symbol_win.cc	View		1 chunk	+3 lines, -1 line	0 comments	Download

Total messages: 5 (2 generated)

Florian Schneider

3 years, 9 months ago (2017-03-22 21:50:24 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
030473f0ffb4bb72fa35d3995fe735fb9731e1fd (presubmit successful).