Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(8519)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Unified Diff: chrome/test/data/webapks/empty.apk
Issue
2772483002
:
Commment signed webapks working and verified. (Closed)
Patch Set: Fix setting of flags.
Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Jump to:
chrome/android/java/src/org/chromium/chrome/browser/ChromeSwitches.java
chrome/android/java/src/org/chromium/chrome/browser/preferences/ChromePreferenceManager.java
chrome/android/java/src/org/chromium/chrome/browser/webapps/ChromeWebApkHost.java
chrome/android/java/src/org/chromium/chrome/browser/webapps/ChromeWebApkHostSignature.java
chrome/android/webapk/libs/client/BUILD.gn
chrome/android/webapk/libs/client/junit/src/org/chromium/webapk/lib/client/WebApkValidatorTest.java
chrome/android/webapk/libs/client/junit/src/org/chromium/webapk/lib/client/WebApkVerifySignatureTest.java
chrome/android/webapk/libs/client/src/org/chromium/webapk/lib/client/WebApkValidator.java
chrome/android/webapk/libs/client/src/org/chromium/webapk/lib/client/WebApkVerifySignature.java
chrome/test/data/webapks/bad-sig.apk
chrome/test/data/webapks/bad-utf8-fname.apk
chrome/test/data/webapks/empty.apk
chrome/test/data/webapks/example.apk
chrome/test/data/webapks/extra-len-too-large.apk
chrome/test/data/webapks/fcomment-too-large.apk
chrome/test/data/webapks/java-example.apk
chrome/test/data/webapks/no-cd.apk
chrome/test/data/webapks/no-comment.apk
chrome/test/data/webapks/no-eocd.apk
chrome/test/data/webapks/no-lfh.apk
chrome/test/data/webapks/not-an.apk
chrome/test/data/webapks/public.der
chrome/test/data/webapks/too-many-metainf.apk
chrome/test/data/webapks/truncated.apk
chrome/test/data/webapks/zeros.apk
chrome/test/data/webapks/zeros-at-end.apk
View side-by-side diff with in-line comments
Download patch
« no previous file with comments
|
« chrome/test/data/webapks/bad-utf8-fname.apk
('k') |
chrome/test/data/webapks/example.apk »
('j') |
no next file with comments »
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
Index: chrome/test/data/webapks/empty.apk
diff --git a/chrome/test/data/webapks/empty.apk b/chrome/test/data/webapks/empty.apk
new file mode 100644
index 0000000000000000000000000000000000000000..e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
« no previous file with comments
|
« chrome/test/data/webapks/bad-utf8-fname.apk
('k') |
chrome/test/data/webapks/example.apk »
('j') |
no next file with comments »
Issue 2772483002: Commment signed webapks working and verified. (Closed)
Created 3 years, 9 months ago by ScottK
Modified 3 years, 8 months ago
Reviewers: agrieve, pkotwicz, Yaron, Robert Sesek
Base URL:
Comments: 271
This is Rietveld
408576698