Commment signed webapks working and verified.

chrome/android/java/src/org/chromium/chrome/browser/webapps/ChromeWebApkHost.java

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser.webapps;
 
 import android.content.Context;
 import android.os.StrictMode;
 import android.provider.Settings;
 
 import org.chromium.base.ContextUtils;
 import org.chromium.base.Log;
 import org.chromium.base.annotations.CalledByNative;
 import org.chromium.base.library_loader.LibraryLoader;
 import org.chromium.chrome.browser.AppHooks;
 import org.chromium.chrome.browser.ChromeFeatureList;
 import org.chromium.chrome.browser.GooglePlayInstallState;
 import org.chromium.chrome.browser.externalauth.ExternalAuthUtils;
 import org.chromium.chrome.browser.externalauth.UserRecoverableErrorHandler;
 import org.chromium.chrome.browser.preferences.ChromePreferenceManager;
 import org.chromium.webapk.lib.client.WebApkValidator;
 
-/**
- * Contains functionality needed for Chrome to host WebAPKs.
- */
+/** Contains functionality needed for Chrome to host WebAPKs. */
 public class ChromeWebApkHost {
     private static final String TAG = "ChromeWebApkHost";
 
     /** Whether installing WebAPks from Google Play is possible. */
     private static Integer sGooglePlayInstallState;
 
     private static Boolean sEnabledForTesting;
 
     public static void init() {
-        WebApkValidator.initWithBrowserHostSignature(ChromeWebApkHostSignature.EXPECTED_SIGNATURE);
+        WebApkValidator.initWithBrowserHostSignature(
+                ChromeWebApkHostSignature.EXPECTED_SIGNATURE, ChromeWebApkHostSignature.PUBLIC_KEY);
     }
 
     public static void initForTesting(boolean enabled) {
         sEnabledForTesting = enabled;
     }
 
     public static boolean isEnabled() {
         if (sEnabledForTesting != null) return sEnabledForTesting;
 
         return isEnabledInPrefs();
@@ skipping 25 matching lines @@
         GooglePlayWebApkInstallDelegate delegate =
                 AppHooks.get().getGooglePlayWebApkInstallDelegate();
         if (delegate == null) {
             return GooglePlayInstallState.DISABLED_OTHER;
         }
 
         return GooglePlayInstallState.SUPPORTED;
     }
 
     /**
-     * Returns whether installing WebAPKs from Google Play is possible.
-     * If {@link sCanUseGooglePlayInstall} hasn't been set yet, it returns false immediately and
-     * calls the Google Play Install API to update {@link sCanUseGooglePlayInstall} asynchronously.
+     * Returns whether installing WebAPKs from Google Play is possible. If {@link

[pkotwicz, 2017/03/31 03:59:24]

Keep {@link} on the same line

[ScottK, 2017/04/03 17:44:17]

done.

+     * sCanUseGooglePlayInstall} hasn't been set yet, it returns false immediately and calls the
+     * Google Play Install API to update {@link sCanUseGooglePlayInstall} asynchronously.
      */
-    private static boolean canUseGooglePlayToInstallWebApk() {
+    public static boolean canUseGooglePlayToInstallWebApk() {

[pkotwicz, 2017/03/31 03:59:24]

Why this change?

[ScottK, 2017/04/03 17:44:17]

I  don't understand this change, unless it was a bad merge on my part?
Reverted.

         return getGooglePlayInstallState() == GooglePlayInstallState.SUPPORTED;
     }
 
     /**
      * Returns whether Google Play install is enabled by Chrome. Does not check whether installing
      * from Google Play is possible.
      */
     public static boolean isGooglePlayInstallEnabledByChromeFeature() {
         return isEnabled() && LibraryLoader.isInitialized()
                 && nativeCanUseGooglePlayToInstallWebApk();
@@ skipping 19 matching lines @@
 
     /* Returns whether launching renderer in WebAPK process is enabled by Chrome. */
     public static boolean canLaunchRendererInWebApkProcess() {
         return isEnabled() && LibraryLoader.isInitialized()
                 && nativeCanLaunchRendererInWebApkProcess();
     }
 
     /**
      * Check the cached value to figure out if the feature is enabled. We have to use the cached
      * value because native library may not yet been loaded.
+     *
      * @return Whether the feature is enabled.
      */
     private static boolean isEnabledInPrefs() {
         // Will go away once the feature is enabled for everyone by default.
         StrictMode.ThreadPolicy oldPolicy = StrictMode.allowThreadDiskReads();
         try {
             return ChromePreferenceManager.getInstance().getCachedWebApkRuntimeEnabled();
         } finally {
             StrictMode.setThreadPolicy(oldPolicy);
         }
@@ skipping 23 matching lines @@
         try {
             return Settings.Secure.getInt(applicationContext.getContentResolver(),
                            Settings.Secure.INSTALL_NON_MARKET_APPS)
                     == 1;
         } catch (Settings.SettingNotFoundException e) {
             return false;
         }
     }
 
     private static native boolean nativeCanUseGooglePlayToInstallWebApk();
+
     private static native boolean nativeCanLaunchRendererInWebApkProcess();
+
     private static native boolean nativeCanInstallFromUnknownSources();
 }