Add more documentation to `Future.then` and `Future.catchError`.

Add more documentation to `Future.then` and `Future.catchError`.

Fixes #29129
BUG= http://dartbug.com/29129
R=lrn@google.com

Committed: https://github.com/dart-lang/sdk/commit/353a2288bec36a1086ade4e392d190b8b9a75e6a

[floitsch, 2017-03-22 18:25:32]

floitsch@google.com changed reviewers:
+ lrn@google.com

[Lasse Reichstein Nielsen, 2017-03-22 18:36:48]

lgtm

https://codereview.chromium.org/2772463002/diff/20001/sdk/lib/async/future.dart
File sdk/lib/async/future.dart (right):

https://codereview.chromium.org/2772463002/diff/20001/sdk/lib/async/future.da...
sdk/lib/async/future.dart:504: * Note that futures don't wait for listeners to
handle errors. If the
First sentence is a little unclear to me.
How about:

Note that a futures won't delay reporting of errors until a listener is added.

https://codereview.chromium.org/2772463002/diff/20001/sdk/lib/async/future.da...
sdk/lib/async/future.dart:505: * `then` call happens after this future has
completed with an error then
If the *first* `then` call happens ...

(and drop the "unless there was another listener").

Ditto below.

[floitsch, 2017-03-22 19:09:58]

https://codereview.chromium.org/2772463002/diff/20001/sdk/lib/async/future.dart
File sdk/lib/async/future.dart (right):

https://codereview.chromium.org/2772463002/diff/20001/sdk/lib/async/future.da...
sdk/lib/async/future.dart:504: * Note that futures don't wait for listeners to
handle errors. If the
On 2017/03/22 18:36:48, Lasse Reichstein Nielsen wrote:
> First sentence is a little unclear to me.
> How about:
> 
> Note that a futures won't delay reporting of errors until a listener is added.
> 

Done.

https://codereview.chromium.org/2772463002/diff/20001/sdk/lib/async/future.da...
sdk/lib/async/future.dart:505: * `then` call happens after this future has
completed with an error then
On 2017/03/22 18:36:48, Lasse Reichstein Nielsen wrote:
> If the *first* `then` call happens ...
> 
> (and drop the "unless there was another listener").
> 
> Ditto below.

Done.

[floitsch, 2017-03-22 19:10:40]

Description was changed from

==========
Add more documentation to `Future.then` and `Future.catchError`.

Fixes #29129
BUG= http://dartbug.com/29129
==========

to

==========
Add more documentation to `Future.then` and `Future.catchError`.

Fixes #29129
BUG= http://dartbug.com/29129
R=lrn@google.com

Committed:
https://github.com/dart-lang/sdk/commit/353a2288bec36a1086ade4e392d190b8b9a75e6a
==========

[floitsch, 2017-03-22 19:10:41]

Committed patchset #3 (id:40001) manually as
353a2288bec36a1086ade4e392d190b8b9a75e6a (presubmit successful).