Add EditingMarkerList in preparation for DocumentMarkerController refactor

third_party/WebKit/Source/core/editing/markers/EditingMarkerList.h

+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef EditingMarkerList_h
+#define EditingMarkerList_h
+
+#include "core/editing/markers/DocumentMarkerList.h"
+
+namespace blink {
+
+class DocumentMarker;
+
+class CORE_EXPORT EditingMarkerList : public DocumentMarkerList {

[Xiaocheng, 2017/03/27 22:46:22]

It's better to also document its behavior in the code, not just in the patch
description.

+ public:
+  explicit EditingMarkerList();
+
+  // DocumentMarkerList implementations
+  bool isEditingMarkerList() const final;

[Xiaocheng, 2017/03/27 22:46:22]

Please move all overridden functions to private.

[rlanday, 2017/03/28 01:05:07]

As we discussed offline, I'm going to leave these as-is since we sometimes need
to access DocumentMarkerList through a pointer to a derived class (to call
methods that only exist on the derived class)

+
+  void add(DocumentMarker*) override;
+  void clear() final;
+
+  DECLARE_VIRTUAL_TRACE();
+
+ protected:
+  // TODO(rlanday): determine if/when we should sort the marker list to improve
+  // performance
+  bool markerListIsSorted() const final;
+
+  bool m_markersAreSorted;
+
+  DISALLOW_COPY_AND_ASSIGN(EditingMarkerList);
+};
+
+DEFINE_TYPE_CASTS(EditingMarkerList,
+                  DocumentMarkerList,
+                  list,
+                  list->isEditingMarkerList(),
+                  list.isEditingMarkerList());
+
+}  // namespace blink
+
+#endif  // EditingMarkerList_h