Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Unified Diff: chrome/browser/feedback/system_logs/log_sources/chrome_internal_log_source.cc

Issue 2772403004: Add info on extensions to detect malicious extensions (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/feedback/system_logs/log_sources/chrome_internal_log_source.cc
diff --git a/chrome/browser/feedback/system_logs/log_sources/chrome_internal_log_source.cc b/chrome/browser/feedback/system_logs/log_sources/chrome_internal_log_source.cc
index 0f4eb5dd3e4ae07cc2ad402f1e939c890b9acb85..68e086d40919d1fad966f59750d2156233ab4dd3 100644
--- a/chrome/browser/feedback/system_logs/log_sources/chrome_internal_log_source.cc
+++ b/chrome/browser/feedback/system_logs/log_sources/chrome_internal_log_source.cc
@@ -5,6 +5,7 @@
#include "chrome/browser/feedback/system_logs/log_sources/chrome_internal_log_source.h"
#include "base/json/json_string_value_serializer.h"
+#include "base/strings/string_util.h"
#include "base/sys_info.h"
#include "base/task_scheduler/post_task.h"
#include "build/build_config.h"
@@ -202,14 +203,18 @@ void ChromeInternalLogSource::PopulateExtensionInfoLogs(
std::string extensions_list;
for (const scoped_refptr<const extensions::Extension>& extension :
extension_registry->enabled_extensions()) {
- if (extensions_list.empty()) {
- extensions_list = extension->name();
- } else {
- extensions_list += ",\n" + extension->name();
- }
+ // Format the list as:
+ // "extension_id" : "extension_name" : "extension_version".
+
+ // Work around the anonymizer tool recognizing some versions as IPv4s.
+ // Replaces dots "." by underscores "_".
+ // We shouldn't change the anonymizer tool as it is working as intended; it
+ // must err on the side of safety.
+ std::string version;
+ base::ReplaceChars(extension->VersionString(), ".", "_", &version);
+ extensions_list += extension->id() + " : " + extension->name() +
+ " : version " + version + "\n";
}
- if (!extensions_list.empty())
- extensions_list += "\n";
if (!extensions_list.empty())
(*response)[kExtensionsListKey] = extensions_list;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698