Issue 2772373002: [draft] Patch to check potential memory leak

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2772373002: [draft] Patch to check potential memory leak (Closed)

Created:
3 years, 8 months ago by etienneb

Modified:
3 years, 8 months ago

Reviewers:
erikchen

CC:
chromium-reviews, qsr+mojo_chromium.org, vmpstr+watch_chromium.org, wfh+watch_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, tracing+reviews_chromium.org, darin (slow to review)

Target Ref:
refs/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

[draft] Patch to check potential memory leak B=704938 FIXED: https://codereview.chromium.org/2772373002/

Patch Set 1 #

Patch Set 2 : nits #

Patch Set 3 : thread-safe #

Total comments: 1

Patch Set 4 : double counting #

Created: 3 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -1 line)			Patch
	M	base/trace_event/heap_profiler_allocation_context.h	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	mojo/edk/system/channel.cc	View	1 2 3	4 chunks	+10 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

erikchen

https://codereview.chromium.org/2772373002/diff/40001/mojo/edk/system/channel.cc File mojo/edk/system/channel.cc (right): https://codereview.chromium.org/2772373002/diff/40001/mojo/edk/system/channel.cc#newcode61 mojo/edk/system/channel.cc:61: : Message(payload_size, max_handles, MessageType::NORMAL_LEGACY) { this constructor calls another ...

3 years, 8 months ago (2017-03-27 19:10:35 UTC) #2

Closing this patch.
The leak got fixed.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages