[ash-md] WIP Added wallpaper color caching.

chrome/browser/ui/ash/ash_init.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/ash/ash_init.h"
 
 #include "ash/accelerators/accelerator_controller_delegate_aura.h"
 #include "ash/aura/wm_shell_aura.h"
 #include "ash/common/accelerators/accelerator_controller.h"
 #include "ash/common/accessibility_types.h"
@@ skipping 18 matching lines @@
 #include "chrome/browser/ui/ash/ime_controller_chromeos.h"
 #include "chrome/common/chrome_switches.h"
 #include "chromeos/accelerometer/accelerometer_reader.h"
 #include "chromeos/chromeos_switches.h"
 #include "chromeos/login/login_state.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/browser/context_factory.h"
 #include "ui/aura/env.h"
 #include "ui/aura/window_tree_host.h"
 
+#include "ash/common/wallpaper/wallpaper_controller.h"
+#include "components/wallpaper/pref_based_wallpaper_color_cache.h"
+
 #if defined(USE_X11)
 #include "ui/base/x/x11_util.h"  // nogncheck
 #endif
 
 namespace chrome {
 
 void OpenAsh(gfx::AcceleratedWidget remote_window) {
 #if defined(USE_X11)
   if (base::SysInfo::IsRunningOnChromeOS()) {
     // Hides the cursor outside of the Aura root window. The cursor will be
@@ skipping 42 matching lines @@
   shell->magnification_controller()->SetEnabled(
       magnifier_enabled && magnifier_type == ash::MAGNIFIER_FULL);
   shell->partial_magnification_controller()->SetEnabled(
       magnifier_enabled && magnifier_type == ash::MAGNIFIER_PARTIAL);
 
   if (!base::CommandLine::ForCurrentProcess()->HasSwitch(
           switches::kDisableZeroBrowsersOpenForTests)) {
     g_browser_process->platform_part()->RegisterKeepAlive();
   }
   ash::Shell::GetPrimaryRootWindow()->GetHost()->Show();
+
+  // TODO(bruthig): Is this the right place to initialize the cache? Maybe
+  // it be initialized Ash side and wrap ash::Shell::pref_store() some how?
+  // TODO(bruthig): Merge with master.
+  // TODO(bruthig): Don't leak the cache.
+  ash::Shell::GetInstance()->wallpaper_controller()->SetWallpaperColorCache(

[jonross, 2017/03/28 14:33:28]

This may be more appropriate in the chromeos::WallpaperManager.

Ideally, once the pref service is ready, this would not be needed at all. The
ash::WallpaperController would be able to instantiate the color cache itself.

[bruthig, 2017/03/28 15:18:50]

I tried to initialize the cache in the WallpaperManager in a few places but the
ash::Shell was not available yet I think.

[jonross, 2017/03/28 18:24:35]

That's a bit scary. A lot of login screen code relies heavily on the ash::Shell.

However if there is a weird startup order, this spot could work for setting up
this connection.

+      new wallpaper::PrefBasedWallpaperColorCache(
+          g_browser_process->local_state()));
 }
 
 void CloseAsh() {
   if (ash::Shell::HasInstance()) {
     ash::Shell::DeleteInstance();
     ash::ShellContentState::DestroyInstance();
   }
 }
 
 }  // namespace chrome