Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Unified Diff: third_party/WebKit/LayoutTests/http/tests/streams/writable-streams/close.js

Issue 2772293002: Update WritableStream to new standard version (Closed)
Patch Set: Changes from domenic@ review Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/http/tests/streams/writable-streams/close.js
diff --git a/third_party/WebKit/LayoutTests/http/tests/streams/writable-streams/close.js b/third_party/WebKit/LayoutTests/http/tests/streams/writable-streams/close.js
deleted file mode 100644
index 5c83a5e12839d13460241731c39e467de2a7a399..0000000000000000000000000000000000000000
--- a/third_party/WebKit/LayoutTests/http/tests/streams/writable-streams/close.js
+++ /dev/null
@@ -1,216 +0,0 @@
-'use strict';
-
-if (self.importScripts) {
- self.importScripts('/resources/testharness.js');
- self.importScripts('../resources/test-utils.js');
- self.importScripts('../resources/recording-streams.js');
-}
-
-promise_test(() => {
- const ws = new WritableStream({
- close() {
- return 'Hello';
- }
- });
-
- const writer = ws.getWriter();
-
- const closePromise = writer.close();
- return closePromise.then(value => assert_equals(value, undefined, 'fulfillment value must be undefined'));
-}, 'fulfillment value of ws.close() call must be undefined even if the underlying sink returns a non-undefined ' +
- 'value');
-
-promise_test(t => {
- const passedError = new Error('error me');
- let controller;
- const ws = new WritableStream({
- close(c) {
- controller = c;
- return delay(50);
- }
- });
-
- const writer = ws.getWriter();
-
- return Promise.all([
- writer.close(),
- delay(10).then(() => controller.error(passedError)),
- promise_rejects(t, passedError, writer.closed,
- 'closed promise should be rejected with the passed error'),
- delay(70).then(() => promise_rejects(t, passedError, writer.closed, 'closed should stay rejected'))
- ]);
-}, 'when sink calls error asynchronously while closing, the stream should become errored');
-
-promise_test(t => {
- const passedError = new Error('error me');
- const ws = new WritableStream({
- close(controller) {
- controller.error(passedError);
- }
- });
-
- const writer = ws.getWriter();
-
- return writer.close().then(() => promise_rejects(t, passedError, writer.closed, 'closed should stay rejected'));
-}, 'when sink calls error synchronously while closing, the stream should become errored');
-
-promise_test(() => {
- const ws = recordingWritableStream();
-
- const writer = ws.getWriter();
-
- return writer.ready.then(() => {
- assert_equals(writer.desiredSize, 1, 'desiredSize should be 1');
-
- writer.close();
- assert_equals(writer.desiredSize, 1, 'desiredSize should be still 1');
-
- return writer.ready.then(v => {
- assert_equals(v, undefined, 'ready promise should be fulfilled with undefined');
- assert_array_equals(ws.events, ['close'], 'write and abort should not be called');
- });
- });
-}, 'when close is called on a WritableStream in writable state, ready should return a fulfilled promise');
-
-promise_test(() => {
- const ws = recordingWritableStream({
- write() {
- return new Promise(() => {});
- }
- });
-
- const writer = ws.getWriter();
-
- return writer.ready.then(() => {
- writer.write('a');
-
- assert_equals(writer.desiredSize, 0, 'desiredSize should be 0');
-
- let calledClose = false;
- return Promise.all([
- writer.ready.then(v => {
- assert_equals(v, undefined, 'ready promise should be fulfilled with undefined');
- assert_true(calledClose, 'ready should not be fulfilled before writer.close() is called');
- assert_array_equals(ws.events, ['write', 'a'], 'sink abort() should not be called');
- }),
- flushAsyncEvents().then(() => {
- writer.close();
- calledClose = true;
- })
- ]);
- });
-}, 'when close is called on a WritableStream in waiting state, ready promise should be fulfilled');
-
-promise_test(() => {
- let asyncCloseFinished = false;
- const ws = recordingWritableStream({
- close() {
- return flushAsyncEvents().then(() => {
- asyncCloseFinished = true;
- });
- }
- });
-
- const writer = ws.getWriter();
- return writer.ready.then(() => {
- writer.write('a');
-
- writer.close();
-
- return writer.ready.then(v => {
- assert_false(asyncCloseFinished, 'ready promise should be fulfilled before async close completes');
- assert_equals(v, undefined, 'ready promise should be fulfilled with undefined');
- assert_array_equals(ws.events, ['write', 'a', 'close'], 'sink abort() should not be called');
- });
- });
-}, 'when close is called on a WritableStream in waiting state, ready should be fulfilled immediately even if close ' +
- 'takes a long time');
-
-promise_test(t => {
- const rejection = { name: 'letter' };
- const ws = new WritableStream({
- close() {
- return {
- then(onFulfilled, onRejected) { onRejected(rejection); }
- };
- }
- });
- return promise_rejects(t, rejection, ws.getWriter().close(), 'close() should return a rejection');
-}, 'returning a thenable from close() should work');
-
-promise_test(t => {
- const ws = new WritableStream();
- const writer = ws.getWriter();
- return writer.ready.then(() => {
- const closePromise = writer.close();
- const closedPromise = writer.closed;
- writer.releaseLock();
- return Promise.all([
- closePromise,
- promise_rejects(t, new TypeError(), closedPromise, '.closed promise should be rejected')
- ]);
- });
-}, 'releaseLock() should not change the result of sync close()');
-
-promise_test(t => {
- const ws = new WritableStream({
- close() {
- return flushAsyncEvents();
- }
- });
- const writer = ws.getWriter();
- return writer.ready.then(() => {
- const closePromise = writer.close();
- const closedPromise = writer.closed;
- writer.releaseLock();
- return Promise.all([
- closePromise,
- promise_rejects(t, new TypeError(), closedPromise, '.closed promise should be rejected')
- ]);
- });
-}, 'releaseLock() should not change the result of async close()');
-
-promise_test(() => {
- let resolveClose;
- const ws = new WritableStream({
- close() {
- const promise = new Promise(resolve => {
- resolveClose = resolve;
- });
- return promise;
- }
- });
- const writer = ws.getWriter();
- const closePromise = writer.close();
- writer.releaseLock();
- return delay(0).then(() => {
- resolveClose();
- return closePromise.then(() => {
- assert_equals(ws.getWriter().desiredSize, 0, 'desiredSize should be 0');
- });
- });
-}, 'close() should set state to CLOSED even if writer has detached');
-
-promise_test(() => {
- let resolveClose;
- const ws = new WritableStream({
- close() {
- const promise = new Promise(resolve => {
- resolveClose = resolve;
- });
- return promise;
- }
- });
- const writer = ws.getWriter();
- writer.close();
- writer.releaseLock();
- return delay(0).then(() => {
- const abortingWriter = ws.getWriter();
- const abortPromise = abortingWriter.abort();
- abortingWriter.releaseLock();
- resolveClose();
- return abortPromise;
- });
-}, 'the promise returned by async abort during close should resolve');
-
-done();

Powered by Google App Engine
This is Rietveld 408576698