Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Unified Diff: net/url_request/url_request_context.cc

Issue 2772283003: Make url_request_context dumps include context names (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/url_request/url_request_context.cc
diff --git a/net/url_request/url_request_context.cc b/net/url_request/url_request_context.cc
index a7b02337c3da375d6c7d3a2a731cd38c2ec24e78..198c43a22bc267561a77361a563194afed9ef2eb 100644
--- a/net/url_request/url_request_context.cc
+++ b/net/url_request/url_request_context.cc
@@ -144,18 +144,14 @@ bool URLRequestContext::OnMemoryDump(
SSLClientSocketImpl::DumpSSLClientSessionMemoryStats(pmd);
- std::string dump_name = base::StringPrintf(
- "net/url_request_context_0x%" PRIxPTR, reinterpret_cast<uintptr_t>(this));
+ std::string dump_name =
+ base::StringPrintf("net/url_request_context/%s/0x%" PRIxPTR,
+ name_.c_str(), reinterpret_cast<uintptr_t>(this));
ssid 2017/03/27 18:43:15 Are we sure that we know all the possible names he
xunjieli 2017/03/27 19:24:55 Done.
base::trace_event::MemoryAllocatorDump* dump =
pmd->CreateAllocatorDump(dump_name);
dump->AddScalar(base::trace_event::MemoryAllocatorDump::kNameObjectCount,
base::trace_event::MemoryAllocatorDump::kUnitsObjects,
url_requests_->size());
- if (args.level_of_detail !=
- base::trace_event::MemoryDumpLevelOfDetail::BACKGROUND) {
- dump->AddString("origin",
- base::trace_event::MemoryAllocatorDump::kTypeString, name_);
- }
HttpTransactionFactory* transaction_factory = http_transaction_factory();
if (transaction_factory) {
HttpNetworkSession* network_session = transaction_factory->GetSession();
« base/trace_event/memory_infra_background_whitelist.cc ('K') | « net/http/http_cache_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698