Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1669)

Unified Diff: third_party/WebKit/Source/core/css/properties/CSSPropertyCounterUtils.cpp

Issue 2772263004: Added CSSPropertyCounterUtils which holds shared counter parsing logic. (Closed)
Patch Set: addressed reviewer comment Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/css/properties/CSSPropertyCounterUtils.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/css/properties/CSSPropertyCounterUtils.cpp
diff --git a/third_party/WebKit/Source/core/css/properties/CSSPropertyCounterUtils.cpp b/third_party/WebKit/Source/core/css/properties/CSSPropertyCounterUtils.cpp
new file mode 100644
index 0000000000000000000000000000000000000000..c93ca91a6d66a5301b8d99ac63999daf4f308d6d
--- /dev/null
+++ b/third_party/WebKit/Source/core/css/properties/CSSPropertyCounterUtils.cpp
@@ -0,0 +1,38 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "core/css/properties/CSSPropertyCounterUtils.h"
+
+#include "core/css/CSSValueList.h"
+#include "core/css/CSSValuePair.h"
+#include "core/css/parser/CSSParserTokenRange.h"
+#include "core/css/parser/CSSPropertyParserHelpers.h"
+
+namespace blink {
+
+CSSValue* CSSPropertyCounterUtils::consumeCounter(
+ CSSParserTokenRange& range,
+ CounterDefaultValue defaultValue) {
+ if (range.peek().id() == CSSValueNone)
+ return CSSPropertyParserHelpers::consumeIdent(range);
+
+ CSSValueList* list = CSSValueList::createSpaceSeparated();
+ do {
+ CSSCustomIdentValue* counterName =
+ CSSPropertyParserHelpers::consumeCustomIdent(range);
+ if (!counterName)
+ return nullptr;
+ int value = static_cast<int>(defaultValue);
suzyh_UTC10 (ex-contributor) 2017/03/28 02:26:08 This int-iness enum-iness arrangement is a bit wei
+ if (CSSPrimitiveValue* counterValue =
+ CSSPropertyParserHelpers::consumeInteger(range))
+ value = clampTo<int>(counterValue->getDoubleValue());
suzyh_UTC10 (ex-contributor) 2017/03/28 02:26:08 Would it make sense to use getIntValue() instead t
Bugs Nash 2017/03/28 02:32:50 I think we're experiencing creep here? This is a r
+ list->append(*CSSValuePair::create(
+ counterName,
+ CSSPrimitiveValue::create(value, CSSPrimitiveValue::UnitType::Integer),
+ CSSValuePair::DropIdenticalValues));
+ } while (!range.atEnd());
+ return list;
+}
+
+} // namespace blink
« no previous file with comments | « third_party/WebKit/Source/core/css/properties/CSSPropertyCounterUtils.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698