Added leanback support libraries as dependencies

Added leanback support libraries as dependencies

Test: Rebuilt and deployed app to fugu

[sandv, 2017-03-28 23:54:57]

Description was changed from

==========
Added leanback support libraries as dependencies

Bug:31223668
Test: Rebuilt and deployed app to fugu
Change-Id: I08ac9f58d640c3b5fde5f2f969296b725b6b3bea
(cherry picked from commit e5c73b839aa338a39252d309cdeb024ec663ee4c)
==========

to

==========
Added leanback support libraries as dependencies

Bug:31223668
Test: Rebuilt and deployed app to fugu
Change-Id: I08ac9f58d640c3b5fde5f2f969296b725b6b3bea
(cherry picked from commit e5c73b839aa338a39252d309cdeb024ec663ee4c)
==========

[sandv, 2017-03-28 23:54:57]

sandv@chromium.org changed reviewers:
+ dpranke@chromium.org, sanfin@chromium.org

[sandv, 2017-03-28 23:55:56]

sandv@chromium.org changed reviewers:
+ halliwell@chromium.org

[Simeon, 2017-03-29 00:46:53]

The CQ bit was checked by sanfin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-29 00:47:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-29 00:47:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-29 00:47:33]

Dry run: Your CL can not be processed by CQ because of:
 * target_ref must start with "refs/".
   Hint: re-upload your CL with proper --target_branch or omit --target_branch
argument entirely

[Simeon, 2017-03-29 00:51:38]

On 2017/03/28 23:56:03, sandv wrote:

Please remove the Change-Id and cherry pick messages from the commit message.

[sandv, 2017-03-29 00:54:40]

Description was changed from

==========
Added leanback support libraries as dependencies

Bug:31223668
Test: Rebuilt and deployed app to fugu
Change-Id: I08ac9f58d640c3b5fde5f2f969296b725b6b3bea
(cherry picked from commit e5c73b839aa338a39252d309cdeb024ec663ee4c)
==========

to

==========
Added leanback support libraries as dependencies

Bug:31223668
Test: Rebuilt and deployed app to fugu
==========

[sandv, 2017-03-29 00:58:50]

On 2017/03/29 00:51:38, Simeon wrote:
> On 2017/03/28 23:56:03, sandv wrote:
> 
> Please remove the Change-Id and cherry pick messages from the commit message.

Fixed

[halliwell, 2017-03-29 01:05:52]

https://codereview.chromium.org/2772253005/diff/1/build/secondary/third_party...
File build/secondary/third_party/android_tools/BUILD.gn (right):

https://codereview.chromium.org/2772253005/diff/1/build/secondary/third_party...
build/secondary/third_party/android_tools/BUILD.gn:185:
android_aar_prebuilt("android_support_v17_preference_java") {
should this have leanback in its name?

[sandv, 2017-03-29 17:10:45]

> should this have leanback in its name?

I didn't because the package name does not have leanback in its name: 
https://developer.android.com/reference/android/support/v17/preference/packag...

[halliwell, 2017-03-29 19:48:00]

On 2017/03/29 17:10:45, sandv wrote:
> > should this have leanback in its name?
> 
> I didn't because the package name does not have leanback in its name: 
>
https://developer.android.com/reference/android/support/v17/preference/packag...

I see, thanks.  I was just going off the lib_name part below.
lgtm

[sandv, 2017-03-31 21:31:44]

The CQ bit was checked by sandv@chromium.org

[sandv, 2017-03-31 21:31:45]

The CQ bit was unchecked by sandv@chromium.org

[sandv, 2017-03-31 21:32:02]

The CQ bit was checked by sandv@chromium.org

[sandv, 2017-03-31 21:32:02]

The CQ bit was unchecked by sandv@chromium.org

[Dirk Pranke, 2017-03-31 23:10:37]

lgtm

[sandv, 2017-04-03 17:27:05]

The CQ bit was checked by sandv@chromium.org

[sandv, 2017-04-03 17:27:05]

The CQ bit was unchecked by sandv@chromium.org

[sandv, 2017-04-03 17:36:53]

The CQ bit was checked by sandv@chromium.org

[commit-bot: I haz the power, 2017-04-03 17:37:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-03 17:37:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-03 17:37:27]

Your CL can not be processed by CQ because of:
 * target_ref must start with "refs/".
   Hint: re-upload your CL with proper --target_branch or omit --target_branch
argument entirely

[Simeon, 2017-04-03 17:59:06]

The CQ bit was checked by sanfin@chromium.org

[Simeon, 2017-04-03 17:59:07]

The patchset sent to the CQ was uploaded after l-g-t-m from
dpranke@chromium.org, halliwell@chromium.org
Link to the patchset: https://codereview.chromium.org/2772253005/#ps20001
(title: "Added leanback support libraries as dependencies")

[commit-bot: I haz the power, 2017-04-03 17:59:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-03 17:59:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-03 17:59:53]

Your CL can not be processed by CQ because of:
 * target_ref must start with "refs/".
   Hint: re-upload your CL with proper --target_branch or omit --target_branch
argument entirely

[Simeon, 2017-04-03 18:10:56]

Nit: in the commit message, you link to an internal bug ID. Chromium has its own
bug tracker at crbug.com, but we usually write "BUG=Internal b/<bug ID>" for
changes tracking internal bugs.

[sandv, 2017-04-03 18:14:25]

Description was changed from

==========
Added leanback support libraries as dependencies

Bug:31223668
Test: Rebuilt and deployed app to fugu
==========

to

==========
Added leanback support libraries as dependencies

Test: Rebuilt and deployed app to fugu
==========