Issue 277223004: Addressing dialog cropping by the virtual keyboard for M36

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 277223004: Addressing dialog cropping by the virtual keyboard for M36 (Closed)

Created:
6 years, 7 months ago by Mr4D (OOO till 08-26)

Modified:
6 years, 7 months ago

Reviewers:
sky

CC:
chromium-reviews, kalyank, sadrul, ben+ash_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Addressing dialog cropping by the virtual keyboard for M36 BUG=370925 TEST=ash_unittests and visual (using wifi advanced dialog which is the biggest known dialog) Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269947

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+76 lines, -4 lines)			Patch
	M	ash/wm/system_modal_container_layout_manager.cc	View		1 chunk	+13 lines, -4 lines	0 comments	Download
	M	ash/wm/system_modal_container_layout_manager_unittest.cc	View		1 chunk	+63 lines, -0 lines	0 comments	Download

Total messages: 6 (0 generated)

Mr4D (OOO till 08-26)

After discussing with jennchen and kevers, we do for M36 the simplest approach possible: We ...

6 years, 7 months ago (2014-05-12 20:00:29 UTC) #1

Mr4D (OOO till 08-26)

The CQ bit was checked by skuhne@chromium.org

6 years, 7 months ago (2014-05-12 21:03:22 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skuhne@chromium.org/277223004/1

6 years, 7 months ago (2014-05-12 21:05:54 UTC) #5

Message was sent while issue was closed.

Change committed as 269947