chrome/common/extensions/features/simple_feature_unittest.cc - Issue 27722003: Windows-specific implementation of Networking Private API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/features/simple_feature_unittest.cc

Issue 27722003: Windows-specific implementation of Networking Private API. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Renamed feature platforms to 'win' and 'mac' to match Platforms from model.py Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/common/extensions/features/simple_feature_unittest.cc

diff --git a/chrome/common/extensions/features/simple_feature_unittest.cc b/chrome/common/extensions/features/simple_feature_unittest.cc

index d4f4c0a48c3d19436c55224cc40fe82f3548db21..2b02c88ac6ac19a50857b5785ce6263064df21e1 100644

--- a/chrome/common/extensions/features/simple_feature_unittest.cc

+++ b/chrome/common/extensions/features/simple_feature_unittest.cc

@@ -471,13 +471,13 @@ TEST_F(ExtensionSimpleFeatureTest, ParsePlatforms) {

EXPECT_EQ(Feature::CHROMEOS_PLATFORM, *feature->platforms()->begin());

platforms->Clear();

- platforms->AppendString("windows");

+ platforms->AppendString("win");

feature->Parse(value.get());

EXPECT_FALSE(feature->platforms()->empty());

EXPECT_EQ(Feature::WIN_PLATFORM, *feature->platforms()->begin());

platforms->Clear();

- platforms->AppendString("windows");

+ platforms->AppendString("win");

platforms->AppendString("chromeos");

feature->Parse(value.get());

std::set<Feature::Platform> expected_platforms;