Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 2772193004: Resolve initialization order fiasco between code_descriptors.cc and token_position.cc. (Closed)

Created:
3 years, 9 months ago by rmacnak
Modified:
3 years, 9 months ago
Reviewers:
Cutch, siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org, siva
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Resolve initialization order fiasco between code_descriptors.cc and token_position.cc. BUG=b/36622728 R=asiva@google.com, johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/0867d8776702530e83eacc9fb08cf32e582fc9d7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -7 lines) Patch
M runtime/vm/code_descriptors.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/token_position.h View 2 chunks +5 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
rmacnak
3 years, 9 months ago (2017-03-27 17:06:59 UTC) #2
siva
lgtm
3 years, 9 months ago (2017-03-27 17:17:25 UTC) #4
Cutch
lgtm
3 years, 9 months ago (2017-03-27 17:19:15 UTC) #5
rmacnak
3 years, 9 months ago (2017-03-27 17:24:10 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
0867d8776702530e83eacc9fb08cf32e582fc9d7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698