[DeviceService] Cleanup of android library dependencies.

services/device/BUILD.gn

Index: services/device/BUILD.gn
diff --git a/services/device/BUILD.gn b/services/device/BUILD.gn
index b6c558ee911a01c37a00d33859049b56683f9174..98bacf342a36a152b28f3c4fce524ed537316194 100644
--- a/services/device/BUILD.gn
+++ b/services/device/BUILD.gn
@@ -11,6 +11,7 @@ if (is_android) {
 }
 
 source_set("lib") {
+  visibility = [ "//content/browser" ]

[blundell, 2017/03/27 08:45:11]

Nit: Add a comment here saying that this should be made visible only to
embedders of the Device Service, and that the dependence should only be for the
purpose of embedding the Device Service.

[leonhsl(Using Gerrit), 2017/03/27 09:13:26]

Done.

   sources = [
     "device_service.cc",
     "device_service.h",
@@ -85,11 +86,8 @@ if (is_android) {
   }
 
   android_library("java") {
-    java_files = [
-      "android/java/src/org/chromium/services/device/InterfaceRegistrar.java",
-      "screen_orientation/android/java/src/org/chromium/device/screen_orientation/ScreenOrientationListener.java",
-      "time_zone_monitor/android/java/src/org/chromium/device/time_zone_monitor/TimeZoneMonitor.java",
-    ]
+    visibility = [ "//content/public/android:*" ]

[blundell, 2017/03/27 08:45:11]

similar nit to above.

[leonhsl(Using Gerrit), 2017/03/27 09:13:27]

Done.

+    java_files = [ "android/java/src/org/chromium/services/device/InterfaceRegistrar.java" ]
     deps = [
       "//base:base_java",
       "//device/battery:mojo_bindings_java",
@@ -99,9 +97,10 @@ if (is_android) {
       "//mojo/android:system_java",
       "//mojo/public/java:bindings_java",
       "//mojo/public/java:system_java",
+      "//services/device/screen_orientation:java",
+      "//services/device/time_zone_monitor:java",
       "//services/service_manager/public/interfaces:interfaces_java",
       "//services/service_manager/public/java:service_manager_java",
-      "//ui/android:ui_java",
     ]
   }
 }