[DeviceService] Cleanup of android library dependencies.

services/device/screen_orientation/BUILD.gn

 # Copyright 2017 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/features.gni")
 
 if (is_android) {
   import("//build/config/android/rules.gni")  # For generate_jni().
 }
 
@@ skipping 20 matching lines @@
 }
 
 if (is_android) {
   generate_jni("screen_orientation_jni_headers") {
     visibility = [ ":screen_orientation" ]
     sources = [
       "android/java/src/org/chromium/device/screen_orientation/ScreenOrientationListener.java",
     ]
     jni_package = "screen_orientation"
   }
+
+  android_library("java") {
+    visibility = [ "//services/device:*" ]

[blundell, 2017/03/27 07:43:43]

maybe just //services/device:java for clarity?

[leonhsl(Using Gerrit), 2017/03/27 08:41:36]

Yeah I tried with //services/device:java before, but trybots complain that some
//services/device:java_XXX targets also need to depend on
//services/device/screen_orientation:java, and seems in GN we can't write like
//services/device:java_*, so I have to use //services/device:* here.

We can see ps#2 fails for such reason and ps#3 is OK.

+    java_files = [ "android/java/src/org/chromium/device/screen_orientation/ScreenOrientationListener.java" ]
+    deps = [
+      "//base:base_java",
+      "//ui/android:ui_java",
+    ]
+  }
 }