Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(449)

Unified Diff: runtime/vm/intermediate_language.cc

Issue 2772143002: Reland "VM: Handle null-comparisons in the flow graph type propagation" (Closed)
Patch Set: address comments Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/intermediate_language.h ('k') | runtime/vm/intrinsifier.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/intermediate_language.cc
diff --git a/runtime/vm/intermediate_language.cc b/runtime/vm/intermediate_language.cc
index 04788e3d6d7b9c6475655476bbc57ad10d48a8d1..f20f1ef58f98085f6820e3d23acbe1d8771bebcd 100644
--- a/runtime/vm/intermediate_language.cc
+++ b/runtime/vm/intermediate_language.cc
@@ -1231,14 +1231,14 @@ void Instruction::Goto(JoinEntryInstr* entry) {
}
-bool UnboxedIntConverterInstr::CanDeoptimize() const {
+bool UnboxedIntConverterInstr::ComputeCanDeoptimize() const {
return (to() == kUnboxedInt32) && !is_truncating() &&
!RangeUtils::Fits(value()->definition()->range(),
RangeBoundary::kRangeBoundaryInt32);
}
-bool UnboxInt32Instr::CanDeoptimize() const {
+bool UnboxInt32Instr::ComputeCanDeoptimize() const {
const intptr_t value_cid = value()->Type()->ToCid();
if (value_cid == kSmiCid) {
return (kSmiBits > 32) && !is_truncating() &&
@@ -1260,7 +1260,7 @@ bool UnboxInt32Instr::CanDeoptimize() const {
}
-bool UnboxUint32Instr::CanDeoptimize() const {
+bool UnboxUint32Instr::ComputeCanDeoptimize() const {
ASSERT(is_truncating());
if ((value()->Type()->ToCid() == kSmiCid) ||
(value()->Type()->ToCid() == kMintCid)) {
@@ -1272,7 +1272,7 @@ bool UnboxUint32Instr::CanDeoptimize() const {
}
-bool BinaryInt32OpInstr::CanDeoptimize() const {
+bool BinaryInt32OpInstr::ComputeCanDeoptimize() const {
switch (op_kind()) {
case Token::kBIT_AND:
case Token::kBIT_OR:
@@ -1296,7 +1296,7 @@ bool BinaryInt32OpInstr::CanDeoptimize() const {
}
-bool BinarySmiOpInstr::CanDeoptimize() const {
+bool BinarySmiOpInstr::ComputeCanDeoptimize() const {
switch (op_kind()) {
case Token::kBIT_AND:
case Token::kBIT_OR:
« no previous file with comments | « runtime/vm/intermediate_language.h ('k') | runtime/vm/intrinsifier.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698