skia/public/interfaces/bitmap.mojom - Issue 2772113004: Make skia.mojom.Bitmap use shared buffer

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: skia/public/interfaces/bitmap.mojom

Issue 2772113004: Make skia.mojom.Bitmap use shared buffer (Closed)

Patch Set: fix gn check Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright 2015 The Chromium Authors. All rights reserved.	1 // Copyright 2015 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 // This file contains structures used to represent SkBitmaps in Mojo.	5 // This file contains structures used to represent SkBitmaps in Mojo.

6 module skia.mojom;	6 module skia.mojom;

7	7

8 // Mirror of SkColorType.	8 // Mirror of SkColorType.

9 enum ColorType {	9 enum ColorType {

10 UNKNOWN,	10 UNKNOWN,

(...skipping 23 matching lines...) Expand all Loading...
34	34

35 struct Bitmap {	35 struct Bitmap {

36 ColorType color_type;	36 ColorType color_type;

37 AlphaType alpha_type;	37 AlphaType alpha_type;

38 ColorProfileType profile_type;	38 ColorProfileType profile_type;

39	39

40 uint32 width;	40 uint32 width;

41 uint32 height;	41 uint32 height;

42 uint64 row_bytes;	42 uint64 row_bytes;

43	43

44 array<uint8> pixel_data;	44 // Handle could be null if the bitmap is empty.

	45 handle<shared_buffer>? pixel_data_buffer_handle;
	msw 2017/03/25 00:59:52 Does it make sense to have our only SkBitmap trans Does it make sense to have our only SkBitmap transport work via shared memory? Don't we then need to guarantee that all users keep their SkBitmaps alive for the unknown duration needed by the remote mojom impl? Ken Rockot(use gerrit already) 2017/03/26 17:52:50 No, the shared buffer is allocated during serializ Show quoted text On 2017/03/25 at 00:59:52, msw wrote: > Does it make sense to have our only SkBitmap transport work via shared memory? Don't we then need to guarantee that all users keep their SkBitmaps alive for the unknown duration needed by the remote mojom impl? No, the shared buffer is allocated during serialization and will remain alive as long as there are any handles referencing it. The bitmap data is copied into the buffer at that point, and the handle sent to the receiver is enough to keep the buffer alive.
45 };	46 };

OLD	NEW

« no previous file with comments | « no previous file | skia/public/interfaces/bitmap_skbitmap_struct_traits.h » ('j') | skia/public/interfaces/bitmap_skbitmap_struct_traits.cc » ('J')