Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(907)

Issue 2771953004: Add patch code for List.filled growable param (Closed)

Created:
3 years, 9 months ago by vsm
Modified:
3 years, 9 months ago
CC:
dev-compiler+reviews_dartlang.org, jakemac
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add patch code for List.filled growable param Looks like a missing param doesn't break patch_sdk. I think this was a recent add. Fixes #28508 R=jakemac@google.com, jmesserly@google.com Committed: https://github.com/dart-lang/sdk/commit/ac68d598cf24f857ccabf702914509a5bdf2feea

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M pkg/dev_compiler/lib/sdk/ddc_sdk.sum View 1 Binary file 0 comments Download
M pkg/dev_compiler/test/browser/language_tests.js View 1 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/dev_compiler/test/not_yet_strong_tests.dart View 1 1 chunk +0 lines, -3 lines 0 comments Download
M pkg/dev_compiler/tool/input_sdk/patch/core_patch.dart View 1 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
vsm
3 years, 9 months ago (2017-03-24 15:56:18 UTC) #3
vsm
3 years, 9 months ago (2017-03-24 15:57:14 UTC) #4
jakemac
lgtm
3 years, 9 months ago (2017-03-24 15:58:45 UTC) #6
Jennifer Messerly
lgtm
3 years, 9 months ago (2017-03-24 20:29:39 UTC) #7
vsm
3 years, 9 months ago (2017-03-24 21:28:00 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:10001) manually as
ac68d598cf24f857ccabf702914509a5bdf2feea (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698