Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3292)

Unified Diff: extensions/browser/content_verify_job.h

Issue 2771953003: Fix content verification code for undreadable and deleted files. (Closed)
Patch Set: address comments change DCHECK Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/browser/content_hash_reader.cc ('k') | extensions/browser/content_verify_job.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/browser/content_verify_job.h
diff --git a/extensions/browser/content_verify_job.h b/extensions/browser/content_verify_job.h
index 15c983ee322fdc1b666f0715115b98c1271f4426..cb7b7e0a8f82fdb898382aa241447543208a42e2 100644
--- a/extensions/browser/content_verify_job.h
+++ b/extensions/browser/content_verify_job.h
@@ -72,6 +72,8 @@ class ContentVerifyJob : public base::RefCountedThreadSafe<ContentVerifyJob> {
class TestDelegate {
public:
+ virtual ~TestDelegate() {}
+
// These methods will be called inside BytesRead/DoneReading respectively.
// If either return something other than NONE, then the failure callback
// will be dispatched with that reason.
@@ -88,7 +90,7 @@ class ContentVerifyJob : public base::RefCountedThreadSafe<ContentVerifyJob> {
virtual void JobFinished(const std::string& extension_id,
const base::FilePath& relative_path,
- bool failed) = 0;
+ FailureReason failure_reason) = 0;
};
// Note: having interleaved delegates is not supported.
« no previous file with comments | « extensions/browser/content_hash_reader.cc ('k') | extensions/browser/content_verify_job.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698