Index: chrome/browser/chromeos/arc/arc_optin_uma.cc |
diff --git a/chrome/browser/chromeos/arc/arc_optin_uma.cc b/chrome/browser/chromeos/arc/arc_optin_uma.cc |
index b52991a391af47a11c5d99cc826273855cf612c3..ac8b77a7c71b98ea28020bfcafbb12627cc34689 100644 |
--- a/chrome/browser/chromeos/arc/arc_optin_uma.cc |
+++ b/chrome/browser/chromeos/arc/arc_optin_uma.cc |
@@ -64,6 +64,13 @@ void UpdateAuthCheckinAttempts(int32_t num_attempts) { |
UMA_HISTOGRAM_SPARSE_SLOWLY("ArcAuth.CheckinAttempts", num_attempts); |
} |
+void UpdateAuthAccountCheckStatus(mojom::AccountCheckStatus status) { |
+ DCHECK(status <= mojom::AccountCheckStatus::CHECK_FAILED); |
Ilya Sherman
2017/03/27 19:03:28
nit: DCHECK_LE
khmel
2017/03/27 19:29:29
Done.
|
+ UMA_HISTOGRAM_ENUMERATION( |
+ "ArcAuth.AccountCheckStatus", static_cast<int>(status), |
+ static_cast<int>(mojom::AccountCheckStatus::CHECK_FAILED) + 1); |
Ilya Sherman
2017/03/27 19:03:28
Hmm, I'm a bit nervous about requiring anyone who
khmel
2017/03/27 19:29:29
IIUC enum in mojom is rather constants (from my ex
Ilya Sherman
2017/03/27 20:07:37
I'm not following what this means. Aren't all enu
khmel
2017/03/27 20:35:57
I got feeling that is slower than 'enum' histogram
Ilya Sherman
2017/03/27 20:54:29
It is a bit slower, yes. It's probably not a mean
khmel
2017/03/27 21:01:41
This code is invoked very infrequently. So sparse
|
+} |
+ |
void UpdateSilentAuthCodeUMA(OptInSilentAuthCode state) { |
UMA_HISTOGRAM_ENUMERATION("Arc.OptInSilentAuthCode", static_cast<int>(state), |
static_cast<int>(OptInSilentAuthCode::SIZE)); |