[Offline pages] Check errors and invalidate pointers only for mainframe for navigation

chrome/browser/android/offline_pages/background_loader_offliner.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/android/offline_pages/background_loader_offliner.h"
 
 #include "base/metrics/histogram_macros.h"
 #include "base/sys_info.h"
 #include "chrome/browser/android/offline_pages/offline_page_mhtml_archiver.h"
 #include "chrome/browser/android/offline_pages/offliner_helper.h"
@@ skipping 210 matching lines @@
 void BackgroundLoaderOffliner::WebContentsDestroyed() {
   if (pending_request_) {
     SavePageRequest request(*pending_request_.get());
     completion_callback_.Run(request, Offliner::RequestStatus::LOADING_FAILED);
     ResetState();
   }
 }
 
 void BackgroundLoaderOffliner::DidFinishNavigation(
     content::NavigationHandle* navigation_handle) {
+  if (!navigation_handle->IsInMainFrame())
+    return;
   // If there was an error of any kind (certificate, client, DNS, etc),
   // Mark as error page. Resetting here causes RecordNavigationMetrics to crash.
   if (navigation_handle->IsErrorPage()) {
     // TODO(chili): we need to UMA this.
     switch (navigation_handle->GetNetErrorCode()) {
       case net::ERR_ACCESS_DENIED:
       case net::ERR_ADDRESS_INVALID:
       case net::ERR_ADDRESS_UNREACHABLE:
       case net::ERR_CERT_COMMON_NAME_INVALID:
       case net::ERR_CERT_AUTHORITY_INVALID:
@@ skipping 16 matching lines @@
       case net::ERR_SSL_CLIENT_AUTH_SIGNATURE_FAILED:
       case net::ERR_SSL_SERVER_CERT_BAD_FORMAT:
       case net::ERR_UNKNOWN_URL_SCHEME:
         page_load_state_ = NONRETRIABLE;
         break;
       default:
         page_load_state_ = RETRIABLE;
     }
   }
 
-  // If the page is not the same, invalidate any pending save tasks.
+  // If the document is not the same invalidate any pending save tasks.
   //
   // Downloads or 204/205 response codes do not commit (no new navigation)
   // Same-Page (committed) navigations are:
   // - reference fragment navigations
   // - pushState/replaceState
   // - same page history navigation
   if (navigation_handle->HasCommitted() && !navigation_handle->IsSamePage())
     weak_ptr_factory_.InvalidateWeakPtrs();
 }
 
@@ skipping 113 matching lines @@
     int64_t offline_id) {
   // If for some reason the request was reset during while waiting for callback
   // ignore the completion callback.
   if (pending_request_ && pending_request_->request_id() != offline_id)
     return;
   completion_callback_.Run(request, RequestStatus::FOREGROUND_CANCELED);
 }
 }  // namespace offline_pages
 
 DEFINE_WEB_CONTENTS_USER_DATA_KEY(offline_pages::OfflinerData);