Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2648)

Unified Diff: components/autofill/content/renderer/password_form_conversion_utils_browsertest.cc

Issue 2771833002: Password Manager should skip fields with credit card autocomplete attribute. (Closed)
Patch Set: Do not create string in HasAutocompleteAttributeValue Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/content/renderer/password_form_conversion_utils_browsertest.cc
diff --git a/components/autofill/content/renderer/password_form_conversion_utils_browsertest.cc b/components/autofill/content/renderer/password_form_conversion_utils_browsertest.cc
index f9d353441a27c7fd5e9231a1a0af6270d16a1284..523226b77230e8b3309573ea072e8bf6d52fcb77 100644
--- a/components/autofill/content/renderer/password_form_conversion_utils_browsertest.cc
+++ b/components/autofill/content/renderer/password_form_conversion_utils_browsertest.cc
@@ -1505,4 +1505,37 @@ TEST_F(MAYBE_PasswordFormConversionUtilsTest, TooManyFieldsToParseForm) {
EXPECT_FALSE(password_form);
}
+TEST_F(MAYBE_PasswordFormConversionUtilsTest, OnlyCreditCardFields) {
+ PasswordFormBuilder builder(kTestFormActionURL);
+ builder.AddTextField("ccname", "johnsmith", "cc-name");
+ builder.AddPasswordField("cc_security_code", "0123456789", "cc-csc");
+ builder.AddSubmitButton("submit");
+ std::string html = builder.ProduceHTML();
+
+ std::unique_ptr<PasswordForm> password_form =
+ LoadHTMLAndConvertForm(html, nullptr, false);
+ EXPECT_FALSE(password_form);
+}
+
+TEST_F(MAYBE_PasswordFormConversionUtilsTest,
+ FieldsWithAndWithoutCreditCardAttributes) {
+ PasswordFormBuilder builder(kTestFormActionURL);
+ builder.AddTextField("username", "johnsmith", nullptr);
+ builder.AddTextField("ccname", "john_smith", "cc-name");
+ builder.AddPasswordField("cc_security_code", "0123456789", "random cc-csc");
+ builder.AddPasswordField("password", "secret", nullptr);
+ builder.AddSubmitButton("submit");
+ std::string html = builder.ProduceHTML();
+
+ std::unique_ptr<PasswordForm> password_form =
+ LoadHTMLAndConvertForm(html, nullptr, false);
+
+ ASSERT_TRUE(password_form);
+
+ EXPECT_EQ(base::UTF8ToUTF16("username"), password_form->username_element);
+ EXPECT_EQ(base::UTF8ToUTF16("johnsmith"), password_form->username_value);
+ EXPECT_EQ(base::UTF8ToUTF16("password"), password_form->password_element);
+ EXPECT_EQ(base::UTF8ToUTF16("secret"), password_form->password_value);
+}
+
} // namespace autofill

Powered by Google App Engine
This is Rietveld 408576698