third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScope.cpp - Issue 2771823002: Implement updateViaCache flag and no-cache by default for main service worker scripts

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScope.cpp

Issue 2771823002: Implement updateViaCache flag and no-cache by default for main service worker scripts

Patch Set: change useCache to updateViaCache Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/service_worker/service_worker_database.proto ('K') | « third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainerTest.cpp ('k') | third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerLinkResource.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScope.cpp

diff --git a/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScope.cpp b/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScope.cpp

index 2c86ff3df9de1c4580d1f142370ae88ba8e80c1e..4bc76128473518b9408b7a0ed2d90ae785f198d0 100644

--- a/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScope.cpp

+++ b/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScope.cpp

@@ -220,6 +220,7 @@ void ServiceWorkerGlobalScope::importScripts(const Vector<String>& urls,

// Bust the MemoryCache to ensure script requests reach the browser-side

// and get added to and retrieved from the ServiceWorker's script cache.

// FIXME: Revisit in light of the solution to crbug/388375.

+ // TODO(yuryu): Update the method to respect cache policy.

for (Vector<String>::const_iterator it = urls.begin(); it != urls.end(); ++it)

GetExecutionContext()->RemoveURLFromMemoryCache(CompleteURL(*it));

WorkerGlobalScope::importScripts(urls, exception_state);