content/browser/service_worker/service_worker_read_from_cache_job_unittest.cc - Issue 2771823002: Implement updateViaCache flag and no-cache by default for main service worker scripts

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_read_from_cache_job_unittest.cc

Issue 2771823002: Implement updateViaCache flag and no-cache by default for main service worker scripts

Patch Set: change useCache to updateViaCache Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/service_worker/service_worker_database.proto ('K') | « content/browser/service_worker/service_worker_provider_host_unittest.cc ('k') | content/browser/service_worker/service_worker_register_job.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_read_from_cache_job_unittest.cc

diff --git a/content/browser/service_worker/service_worker_read_from_cache_job_unittest.cc b/content/browser/service_worker/service_worker_read_from_cache_job_unittest.cc

index ae050d69c26f03f3fb26820112128a95c6272af9..71cc5fb9d18e3dfbcb82463b0bead88645cd30e2 100644

--- a/content/browser/service_worker/service_worker_read_from_cache_job_unittest.cc

+++ b/content/browser/service_worker/service_worker_read_from_cache_job_unittest.cc

@@ -90,9 +90,9 @@ class ServiceWorkerReadFromCacheJobTest : public testing::Test {

run_loop.Run();

// Populate a registration in the storage.

- registration_ =

- new ServiceWorkerRegistration(GURL("http://example.com/scope"),

- kRegistrationId, context()->AsWeakPtr());

+ registration_ = new ServiceWorkerRegistration(

+ ServiceWorkerRegistrationOptions(GURL("http://example.com/scope")),

+ kRegistrationId, context()->AsWeakPtr());

version_ = new ServiceWorkerVersion(registration_.get(), main_script_.url,

kVersionId, context()->AsWeakPtr());

std::vector<ServiceWorkerDatabase::ResourceRecord> resources;