content/browser/background_sync/background_sync_service_impl_unittest.cc - Issue 2771823002: Implement updateViaCache flag and no-cache by default for main service worker scripts

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/background_sync/background_sync_service_impl_unittest.cc

Issue 2771823002: Implement updateViaCache flag and no-cache by default for main service worker scripts

Patch Set: change useCache to updateViaCache Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« android_webview/tools/system_webview_shell/test/data/webexposed/global-interface-listing-expected.txt ('K') | « content/browser/background_sync/background_sync_manager_unittest.cc ('k') | content/browser/browsing_data/clear_site_data_throttle_browsertest.cc » ('j') | content/browser/service_worker/link_header_support.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/background_sync/background_sync_service_impl_unittest.cc

diff --git a/content/browser/background_sync/background_sync_service_impl_unittest.cc b/content/browser/background_sync/background_sync_service_impl_unittest.cc

index 72a64581ae339e33fe9f4b82ee839b788b6a7e8f..75a34791ba4e292616cfa94f5914a151ade6c421 100644

--- a/content/browser/background_sync/background_sync_service_impl_unittest.cc

+++ b/content/browser/background_sync/background_sync_service_impl_unittest.cc

@@ -163,7 +163,8 @@ class BackgroundSyncServiceImplTest : public testing::Test {

void CreateServiceWorkerRegistration() {

bool called = false;

embedded_worker_helper_->context()->RegisterServiceWorker(

- GURL(kServiceWorkerPattern), GURL(kServiceWorkerScript), NULL,

+ GURL(kServiceWorkerScript),

+ ServiceWorkerRegistrationOptions(GURL(kServiceWorkerPattern)), nullptr,

base::Bind(&RegisterServiceWorkerCallback, &called,

&sw_registration_id_));

base::RunLoop().RunUntilIdle();