third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerLinkResource.cpp - Issue 2771823002: Implement updateViaCache flag and no-cache by default for main service worker scripts

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerLinkResource.cpp

Issue 2771823002: Implement updateViaCache flag and no-cache by default for main service worker scripts

Patch Set: fix tests Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainerTest.cpp ('K') | « third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainerTest.cpp ('k') | third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerRegistration.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerLinkResource.cpp

diff --git a/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerLinkResource.cpp b/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerLinkResource.cpp

index bef1adc9711079d21cd39858a993765f97c7ca74..2174e9cb9dc6f4eb7ff2e238e46495005d934013 100644

--- a/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerLinkResource.cpp

+++ b/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerLinkResource.cpp

@@ -80,6 +80,8 @@ void ServiceWorkerLinkResource::process() {

scopeURL = document.completeURL(scope);

scopeURL.removeFragmentIdentifier();

+ bool useCache = m_owner->useCache();

String errorMessage;

ServiceWorkerContainer* container = NavigatorServiceWorker::serviceWorker(

ScriptState::forMainWorld(m_owner->document().frame()),

@@ -96,7 +98,7 @@ void ServiceWorkerLinkResource::process() {

}

container->registerServiceWorkerImpl(

- &document, scriptURL, scopeURL,

+ &document, scriptURL, scopeURL, useCache,

WTF::makeUnique<RegistrationCallback>(m_owner));

}