Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Unified Diff: content/browser/service_worker/service_worker_registration_unittest.cc

Issue 2771823002: Implement updateViaCache flag and no-cache by default for main service worker scripts
Patch Set: fix tests Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_registration_unittest.cc
diff --git a/content/browser/service_worker/service_worker_registration_unittest.cc b/content/browser/service_worker/service_worker_registration_unittest.cc
index 6e1b4442fb11e27c93e2c7c13d359d158c95d60e..f8d2130241fb395554c66565db42788ffd56d02b 100644
--- a/content/browser/service_worker/service_worker_registration_unittest.cc
+++ b/content/browser/service_worker/service_worker_registration_unittest.cc
@@ -104,8 +104,8 @@ TEST_F(ServiceWorkerRegistrationTest, SetAndUnsetVersions) {
const GURL kScript("http://www.example.not/service_worker.js");
int64_t kRegistrationId = 1L;
scoped_refptr<ServiceWorkerRegistration> registration =
- new ServiceWorkerRegistration(kScope, kRegistrationId,
- context()->AsWeakPtr());
+ new ServiceWorkerRegistration(kScope, false /* use_cache */,
+ kRegistrationId, context()->AsWeakPtr());
const int64_t version_1_id = 1L;
const int64_t version_2_id = 2L;
@@ -171,8 +171,8 @@ TEST_F(ServiceWorkerRegistrationTest, FailedRegistrationNoCrash) {
const GURL kScope("http://www.example.not/");
int64_t kRegistrationId = 1L;
scoped_refptr<ServiceWorkerRegistration> registration =
- new ServiceWorkerRegistration(kScope, kRegistrationId,
- context()->AsWeakPtr());
+ new ServiceWorkerRegistration(kScope, false /* use_cache */,
+ kRegistrationId, context()->AsWeakPtr());
std::unique_ptr<ServiceWorkerRegistrationHandle> handle(
new ServiceWorkerRegistrationHandle(
context()->AsWeakPtr(), base::WeakPtr<ServiceWorkerProviderHost>(),
@@ -186,7 +186,8 @@ TEST_F(ServiceWorkerRegistrationTest, NavigationPreload) {
const GURL kScript("https://www.example.not/service_worker.js");
// Setup.
scoped_refptr<ServiceWorkerRegistration> registration =
- new ServiceWorkerRegistration(kScope, storage()->NewRegistrationId(),
+ new ServiceWorkerRegistration(kScope, false /* use_cache */,
+ storage()->NewRegistrationId(),
context()->AsWeakPtr());
scoped_refptr<ServiceWorkerVersion> version_1 = new ServiceWorkerVersion(
registration.get(), kScript, storage()->NewVersionId(),
@@ -230,7 +231,8 @@ class ServiceWorkerActivationTest : public ServiceWorkerRegistrationTest {
const GURL kScript("https://www.example.not/service_worker.js");
registration_ = new ServiceWorkerRegistration(
- kScope, storage()->NewRegistrationId(), context()->AsWeakPtr());
+ kScope, false /* use_cache */, storage()->NewRegistrationId(),
+ context()->AsWeakPtr());
// Create an active version.
scoped_refptr<ServiceWorkerVersion> version_1 = new ServiceWorkerVersion(

Powered by Google App Engine
This is Rietveld 408576698