Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1108)

Unified Diff: content/browser/service_worker/service_worker_context_core.cc

Issue 2771823002: Implement updateViaCache flag and no-cache by default for main service worker scripts
Patch Set: fix tests Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_context_core.cc
diff --git a/content/browser/service_worker/service_worker_context_core.cc b/content/browser/service_worker/service_worker_context_core.cc
index 53997c63c12b60bbc22470893b9ccb2bc4b54ec2..4cab1f7c08edd11cc6c9c922da734b97fc001afc 100644
--- a/content/browser/service_worker/service_worker_context_core.cc
+++ b/content/browser/service_worker/service_worker_context_core.cc
@@ -412,20 +412,16 @@ ServiceWorkerProviderHost* ServiceWorkerContextCore::GetProviderHostByClientID(
}
void ServiceWorkerContextCore::RegisterServiceWorker(
- const GURL& pattern,
const GURL& script_url,
+ const ServiceWorkerRegistrationOptions& options,
ServiceWorkerProviderHost* provider_host,
const RegistrationCallback& callback) {
DCHECK_CURRENTLY_ON(BrowserThread::IO);
was_service_worker_registered_ = true;
job_coordinator_->Register(
- pattern,
- script_url,
- provider_host,
- base::Bind(&ServiceWorkerContextCore::RegistrationComplete,
- AsWeakPtr(),
- pattern,
- callback));
+ script_url, options, provider_host,
+ base::Bind(&ServiceWorkerContextCore::RegistrationComplete, AsWeakPtr(),
+ options.scope, callback));
}
void ServiceWorkerContextCore::UpdateServiceWorker(

Powered by Google App Engine
This is Rietveld 408576698