third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerProvider.h - Issue 2771823002: Implement updateViaCache flag and no-cache by default for main service worker scripts

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerProvider.h

Issue 2771823002: Implement updateViaCache flag and no-cache by default for main service worker scripts

Patch Set: Move API change to another patch and address comments Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerRegistration.cpp ('K') | « third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerRegistration.idl ('k') | third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerRegistration.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerProvider.h

diff --git a/third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerProvider.h b/third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerProvider.h

index d2a64b92a4028de7eb14a87ae1400c0a882484bb..c5cdb127451414c9d6ac06b08a6c43af6c22d7ad 100644

--- a/third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerProvider.h

+++ b/third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerProvider.h

@@ -34,6 +34,7 @@

#include "public/platform/WebCallbacks.h"

#include "public/platform/WebVector.h"

#include "public/platform/modules/serviceworker/WebServiceWorkerRegistration.h"

+#include "public/platform/modules/serviceworker/WebServiceWorkerUpdateViaCache.h"

#include <memory>

@@ -70,6 +71,7 @@ class WebServiceWorkerProvider {

virtual void RegisterServiceWorker(

const WebURL& pattern,

const WebURL& script_url,

+ blink::WebServiceWorkerUpdateViaCache update_via_cache,

std::unique_ptr<WebServiceWorkerRegistrationCallbacks>) {}

virtual void GetRegistration(

const WebURL& document_url,