Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(805)

Unified Diff: content/child/service_worker/service_worker_dispatcher.cc

Issue 2771823002: Implement updateViaCache flag and no-cache by default for main service worker scripts
Patch Set: Move API change to another patch and address comments Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/child/service_worker/service_worker_dispatcher.cc
diff --git a/content/child/service_worker/service_worker_dispatcher.cc b/content/child/service_worker/service_worker_dispatcher.cc
index a3694b2acc8e2715fce32551c492f53a2626487b..2c5db27fc067d0dba72f0edb9d95b7102a1e83be 100644
--- a/content/child/service_worker/service_worker_dispatcher.cc
+++ b/content/child/service_worker/service_worker_dispatcher.cc
@@ -123,6 +123,7 @@ void ServiceWorkerDispatcher::RegisterServiceWorker(
int provider_id,
const GURL& pattern,
const GURL& script_url,
+ blink::WebServiceWorkerUpdateViaCache update_via_cache,
std::unique_ptr<WebServiceWorkerRegistrationCallbacks> callbacks) {
DCHECK(callbacks);
@@ -137,7 +138,7 @@ void ServiceWorkerDispatcher::RegisterServiceWorker(
}
int request_id = pending_registration_callbacks_.Add(std::move(callbacks));
- ServiceWorkerRegistrationOptions options(pattern);
+ ServiceWorkerRegistrationOptions options(pattern, update_via_cache);
TRACE_EVENT_ASYNC_BEGIN2("ServiceWorker",
"ServiceWorkerDispatcher::RegisterServiceWorker",
@@ -188,6 +189,7 @@ void ServiceWorkerDispatcher::GetRegistration(
int request_id =
pending_get_registration_callbacks_.Add(std::move(callbacks));
+
TRACE_EVENT_ASYNC_BEGIN1("ServiceWorker",
"ServiceWorkerDispatcher::GetRegistration",
request_id,

Powered by Google App Engine
This is Rietveld 408576698